From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 422751F454 for ; Fri, 8 Nov 2019 07:27:35 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=eS+Ud UD/aum3GqA30m0TU9rg5UsRh8IEzS0w0YXLursRtPJNIR67sA3i74sHc0ue6xz4k Jl+16eWjUFEtdN1qATs2qtiQDiplqUyKcrwPNEGrGickp3M0XZCdqjJQlYdoy90+ b0GE5BozZFbw38z1oF8+PlJdhMqJLcQn1RD7O4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=ltrAX/khn4M pPfzyB/kUiejhH9c=; b=JSXTIQNOnMMZPNqFF16uOY4S2Z20nYUGzxv6d9ZNbFL f1yHTcvPzKe9oKS7oZP3TlxXM2pAf6LFRImYwlZbKkCSOs0H88Fk8UCDR8EuTF4w xuLl5Lm0Tb9L3O02JMZ7+uVa/qGkuzSrCzHoyc3DlneDYxTRCEQ5Qtea3PH2tbOc = Received: (qmail 70023 invoked by alias); 8 Nov 2019 07:27:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 70009 invoked by uid 89); 8 Nov 2019 07:27:32 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: albireo.enyo.de From: Florian Weimer To: DJ Delorie Cc: libc-alpha@sourceware.org Subject: Re: RFC: test-in-container vs ld.so References: Date: Fri, 08 Nov 2019 08:27:08 +0100 In-Reply-To: (DJ Delorie's message of "Thu, 07 Nov 2019 17:31:50 -0500") Message-ID: <87wocavneb.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain * DJ Delorie: > So... should we run containerized tests without ld.so? Yes, absolutely. It's one of the benefits of running things in a container. But I think we are already doing that? test-container is run via ld.so, but the actual test is not? > 1. Are there tests that *need* the env/ld.so handling within the > container? (not counting test-specific environment variables, I mean > the environment variables we pass to *every* test) We need to set up a predictable locale configuration. But GCONV_PATH and LOCPATH should *not* be set. > 2. how complicated would it be to remove those from the makefile > rules? Alternatively, I suppose test-container itself could remove > them, but better not to hide that logic. I suspect the removalof LC_*, LANG etc. variables should be done in test-container, just for convenience. Then we can just drop $(run-program-env) because it is defined as: # $(run-program-env) is the default environment variable settings to # use when running a program built with the newly built library. run-program-env = GCONV_PATH=$(common-objpfx)iconvdata \ LOCPATH=$(common-objpfx)localedata LC_ALL=C