unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: "Paul A. Clarke" <pc@us.ibm.com>,
	 libc-alpha@sourceware.org,  tuliom@ascii.art.br,
	 law@redhat.com,  carlos@redhat.com
Subject: Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()
Date: Tue, 09 Jul 2019 12:07:29 +0200	[thread overview]
Message-ID: <87sgrfjzby.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <mvmsgrfczab.fsf@suse.de> (Andreas Schwab's message of "Tue, 09 Jul 2019 11:50:20 +0200")

* Andreas Schwab:

> On Jul 09 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> * Paul A. Clarke:
>>
>>> From: "Paul A. Clarke" <pc@us.ibm.com>
>>>
>>> Using __builtin_cpu_supports() requires support in GCC and Glibc.
>>> My recent patch to fpu_control.h added an unprotected use of
>>> __builtin_cpu_supports(), and this is a user-visible file.
>>
>> Are you sure?  I don't think it's an installed header, and that's what
>> “user-visibile file” implies to me.
>
> It's in math/Makefile:headers.

fpu_control.h?  Yes.  But the changed file is
sysdeps/powerpc/fpu/fenv_libc.h, which I don't think is installed.

Thanks,
Florian

  reply	other threads:[~2019-07-09 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 23:54 [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports() Paul A. Clarke
2019-07-09  6:19 ` Florian Weimer
2019-07-09  9:50   ` Andreas Schwab
2019-07-09 10:07     ` Florian Weimer [this message]
2019-07-09 14:23       ` Paul Clarke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgrfjzby.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=law@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=pc@us.ibm.com \
    --cc=schwab@suse.de \
    --cc=tuliom@ascii.art.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).