From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D6F5F1F461 for ; Tue, 9 Jul 2019 10:07:41 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=Qewlft2Il36n216qwf2NUXnVz8ulB/lscvtJFoX/h70 x5sFtiyO+GyPRjIzs8kaDWBSh9MLMcn4yGJft7TwnjonyOs8WhADnMmZmxPJPb2M fvQ4IIzwWKwkY4xNEZo0etL0/mqQmUB69M+W3fYeXELEqs0QKOCpiaf5H7EVmmLM = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=mqIJlJ9LBkAXqCc0HCl099FA3dk=; b=APa2dB0QtI+1OJNwe EqHCmxIIrwoF6/8NhJ+gWSev5DAzmgXLX3FPSAv4ulZC/WXsKzTlue/Hj5t/Rfdk xxeirF0KWw72GIlbCKucbkw4698anMqeExQSubdqLFTTgp6gEd5BY2N/bbzm6vAE RTzxfpIKMMoO1KlEKJouAtjPkY= Received: (qmail 31381 invoked by alias); 9 Jul 2019 10:07:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 31373 invoked by uid 89); 9 Jul 2019 10:07:39 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Andreas Schwab Cc: "Paul A. Clarke" , libc-alpha@sourceware.org, tuliom@ascii.art.br, law@redhat.com, carlos@redhat.com Subject: Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports() References: <1562630076-11320-1-git-send-email-pc@us.ibm.com> <87wogrlogu.fsf@oldenburg2.str.redhat.com> Date: Tue, 09 Jul 2019 12:07:29 +0200 In-Reply-To: (Andreas Schwab's message of "Tue, 09 Jul 2019 11:50:20 +0200") Message-ID: <87sgrfjzby.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable * Andreas Schwab: > On Jul 09 2019, Florian Weimer wrote: > >> * Paul A. Clarke: >> >>> From: "Paul A. Clarke" >>> >>> Using __builtin_cpu_supports() requires support in GCC and Glibc. >>> My recent patch to fpu_control.h added an unprotected use of >>> __builtin_cpu_supports(), and this is a user-visible file. >> >> Are you sure? I don't think it's an installed header, and that's what >> =E2=80=9Cuser-visibile file=E2=80=9D implies to me. > > It's in math/Makefile:headers. fpu_control.h? Yes. But the changed file is sysdeps/powerpc/fpu/fenv_libc.h, which I don't think is installed. Thanks, Florian