From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Martin Sebor via Libc-alpha <libc-alpha@sourceware.org>
Cc: Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] add support for -Wmismatched-dealloc
Date: Mon, 25 Jan 2021 11:56:54 +0100 [thread overview]
Message-ID: <87r1m9jnd5.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <e78b5e6d-391b-5312-cfde-5944bc51f7d3@gmail.com> (Martin Sebor via Libc-alpha's message of "Mon, 11 Jan 2021 17:01:42 -0700")
* Martin Sebor via Libc-alpha:
> diff --git a/libio/stdio.h b/libio/stdio.h
> index 144137cf67..62814c93db 100644
> --- a/libio/stdio.h
> +++ b/libio/stdio.h
> @@ -202,15 +214,9 @@ extern char *tmpnam_r (char *__s) __THROW __wur;
> P_tmpdir is tried and finally "/tmp". The storage for the filename
> is allocated by `malloc'. */
> extern char *tempnam (const char *__dir, const char *__pfx)
> - __THROW __attribute_malloc__ __wur;
> + __attribute_malloc__ __wur __attr_dealloc_free __THROW;
> #endif
This breaks boostrap because in some C++ modes, __THROW (aka noexcept)
needs to come before all attributes.
Further tests are ongoing; this is difficult to do due to general
toolchain breakage (although things have improved lately).
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
next prev parent reply other threads:[~2021-01-25 10:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 22:52 [PATCH] add support for -Wmismatched-dealloc Martin Sebor via Libc-alpha
2020-12-09 0:07 ` Joseph Myers
2020-12-12 2:25 ` Martin Sebor via Libc-alpha
2020-12-14 21:39 ` Martin Sebor via Libc-alpha
2020-12-14 22:16 ` Florian Weimer via Libc-alpha
2020-12-15 1:01 ` Joseph Myers
2020-12-15 16:52 ` Martin Sebor via Libc-alpha
2020-12-27 23:13 ` Martin Sebor via Libc-alpha
2021-01-04 15:56 ` Ping: " Martin Sebor via Libc-alpha
2021-01-04 16:07 ` Florian Weimer via Libc-alpha
2021-01-04 16:18 ` Martin Sebor via Libc-alpha
2021-01-04 16:57 ` Florian Weimer via Libc-alpha
2021-01-04 23:18 ` Martin Sebor via Libc-alpha
2021-01-10 20:42 ` Ping: " Martin Sebor via Libc-alpha
2021-01-11 9:13 ` Florian Weimer via Libc-alpha
2021-01-12 0:00 ` Martin Sebor via Libc-alpha
2021-01-12 0:01 ` Martin Sebor via Libc-alpha
2021-01-12 8:59 ` Florian Weimer via Libc-alpha
2021-01-19 1:08 ` Martin Sebor via Libc-alpha
2021-01-19 16:54 ` David Malcolm via Libc-alpha
2021-01-22 21:26 ` DJ Delorie via Libc-alpha
2021-01-25 10:56 ` Florian Weimer via Libc-alpha [this message]
2021-01-25 11:31 ` Florian Weimer via Libc-alpha
2021-04-23 0:00 ` Martin Sebor via Libc-alpha
2021-05-06 23:54 ` Martin Sebor via Libc-alpha
2021-05-13 21:49 ` Martin Sebor via Libc-alpha
2021-05-16 21:25 ` Martin Sebor via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1m9jnd5.fsf@oldenburg.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).