From: Martin Sebor via Libc-alpha <libc-alpha@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>,
Martin Sebor via Libc-alpha <libc-alpha@sourceware.org>
Cc: Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] add support for -Wmismatched-dealloc
Date: Mon, 4 Jan 2021 09:18:12 -0700 [thread overview]
Message-ID: <0aae9006-6001-8fc8-ad6d-c8e3ee60f82c@gmail.com> (raw)
In-Reply-To: <87mtxok7ob.fsf@oldenburg2.str.redhat.com>
On 1/4/21 9:07 AM, Florian Weimer wrote:
> * Martin Sebor via Libc-alpha:
>
>> diff --git a/wcsmbs/wchar.h b/wcsmbs/wchar.h
>> index 9cf8b05a87..4c1c7f1119 100644
>> --- a/wcsmbs/wchar.h
>> +++ b/wcsmbs/wchar.h
>> @@ -151,7 +151,8 @@ extern size_t wcsxfrm_l (wchar_t *__s1, const wchar_t *__s2,
>> size_t __n, locale_t __loc) __THROW;
>>
>> /* Duplicate S, returning an identical malloc'd string. */
>> -extern wchar_t *wcsdup (const wchar_t *__s) __THROW __attribute_malloc__;
>> +extern wchar_t *wcsdup (const wchar_t *__s) __THROW
>> + __attribute_malloc__ __attr_dealloc_free;
>> #endif
>>
>> /* Find the first occurrence of WC in WCS. */
>> @@ -562,9 +563,18 @@ extern wchar_t *wcpncpy (wchar_t *__restrict __dest,
>> /* Wide character I/O functions. */
>>
>> #if defined __USE_XOPEN2K8 || __GLIBC_USE (LIB_EXT2)
>> +# ifdef __REDIRECT
>> +/* Declare the __fclose alias and associate it as a deallocator
>> + with open_wmemstream below. */
>> +extern int __REDIRECT (__fclose, (FILE *), fclose);
>> +# define __attr_dealloc_fclose __attr_dealloc (__fclose, 1)
>> +# else
>> +# define __attr_dealloc_fclose /* empty */
>> +# endif
>> /* Like OPEN_MEMSTREAM, but the stream is wide oriented and produces
>> a wide character string. */
>> -extern __FILE *open_wmemstream (wchar_t **__bufloc, size_t *__sizeloc) __THROW;
>> +extern __FILE *open_wmemstream (wchar_t **__bufloc, size_t *__sizeloc) __THROW
>> + __attribute_malloc__ __attr_dealloc_fclose;
>> #endif
>>
>> #if defined __USE_ISOC95 || defined __USE_UNIX98
>
> Why is an alias for fclose needed here, but not for free?
Because fclose is not a built-in so there's no __builtin_fclose
to associate open_wmemstream with. free is a built-in and so
__attr_dealloc_free just references __builtin_free and doesn't
need an explicit declaration.
Martin
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2021-01-04 16:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 22:52 [PATCH] add support for -Wmismatched-dealloc Martin Sebor via Libc-alpha
2020-12-09 0:07 ` Joseph Myers
2020-12-12 2:25 ` Martin Sebor via Libc-alpha
2020-12-14 21:39 ` Martin Sebor via Libc-alpha
2020-12-14 22:16 ` Florian Weimer via Libc-alpha
2020-12-15 1:01 ` Joseph Myers
2020-12-15 16:52 ` Martin Sebor via Libc-alpha
2020-12-27 23:13 ` Martin Sebor via Libc-alpha
2021-01-04 15:56 ` Ping: " Martin Sebor via Libc-alpha
2021-01-04 16:07 ` Florian Weimer via Libc-alpha
2021-01-04 16:18 ` Martin Sebor via Libc-alpha [this message]
2021-01-04 16:57 ` Florian Weimer via Libc-alpha
2021-01-04 23:18 ` Martin Sebor via Libc-alpha
2021-01-10 20:42 ` Ping: " Martin Sebor via Libc-alpha
2021-01-11 9:13 ` Florian Weimer via Libc-alpha
2021-01-12 0:00 ` Martin Sebor via Libc-alpha
2021-01-12 0:01 ` Martin Sebor via Libc-alpha
2021-01-12 8:59 ` Florian Weimer via Libc-alpha
2021-01-19 1:08 ` Martin Sebor via Libc-alpha
2021-01-19 16:54 ` David Malcolm via Libc-alpha
2021-01-22 21:26 ` DJ Delorie via Libc-alpha
2021-01-25 10:56 ` Florian Weimer via Libc-alpha
2021-01-25 11:31 ` Florian Weimer via Libc-alpha
2021-04-23 0:00 ` Martin Sebor via Libc-alpha
2021-05-06 23:54 ` Martin Sebor via Libc-alpha
2021-05-13 21:49 ` Martin Sebor via Libc-alpha
2021-05-16 21:25 ` Martin Sebor via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aae9006-6001-8fc8-ad6d-c8e3ee60f82c@gmail.com \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).