unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] ld.so: Hide _r_debug to support DT_DEBUG [BZ #28130]
Date: Mon, 02 Aug 2021 23:19:37 +0200	[thread overview]
Message-ID: <87o8afk0ie.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87h7g8ug94.fsf@igel.home> (Andreas Schwab's message of "Mon, 02 Aug 2021 15:29:27 +0200")

* Andreas Schwab:

> On Aug 01 2021, H.J. Lu via Libc-alpha wrote:
>
>> 1. Add a function, __r_debug_location, which returns the address of
>> _r_debug:
>>
>> /* Return the address of that structure used by the dynamic linker.  */
>> extern struct r_debug * __r_debug_location (void) __attribute_const__;
>>
>> It has a special glibc version, GLIBC_DEBUG.
>>
>> 2. Hide _r_debug in ld.so by defining _r_debug with __r_debug_location:
>>
>>  #define _r_debug (*__r_debug_location ())
>
> There is no need for that.  Nobody should be using _r_debug.

It's declared in a public header.  GNAT and Spindle use it.  Maybe this
needs to be deprecated first before it can be removed.

Thanks,
Florian


  parent reply	other threads:[~2021-08-02 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  4:29 [PATCH 1/2] Map ABI/VERSION of rtld to ABI/VERSION of ld [BZ #28132] H.J. Lu via Libc-alpha
2021-08-02  4:29 ` [PATCH 2/2] ld.so: Hide _r_debug to support DT_DEBUG [BZ #28130] H.J. Lu via Libc-alpha
2021-08-02 13:29   ` Andreas Schwab
2021-08-02 20:43     ` H.J. Lu via Libc-alpha
2021-08-02 21:19     ` Florian Weimer via Libc-alpha [this message]
2021-08-02 21:46       ` H.J. Lu via Libc-alpha
2021-08-02 23:06         ` H.J. Lu via Libc-alpha
2022-10-06 16:38 ` [PATCH 1/2] Map ABI/VERSION of rtld to ABI/VERSION of ld [BZ #28132] Carlos O'Donell via Libc-alpha
2022-10-06 18:46   ` H.J. Lu via Libc-alpha
2022-10-06 19:52     ` H.J. Lu via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8afk0ie.fsf@oldenburg.str.redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).