From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6D4451F8C6 for ; Mon, 2 Aug 2021 21:20:05 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 73676388C022 for ; Mon, 2 Aug 2021 21:20:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73676388C022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627939204; bh=ax4cxkFHwKL35PShBzquXYpiIrWBfV/WXUo9yzNk2Ro=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GXTvL25Hj+jF59NDjSvzOsCCflfs1dnCecICI/HLNdUiBJuUbTpL/pem17ZRj/uol 8Q3vqiKgKPbmWJDoAEyEtLHoS54Zmh0qo29uCy/0QGIX/E0aWVw3tba+tLcner5/Bi cT3OMtPIN00f5Wqos+2Hob9Yu+zy3hZJMVQxbA2g= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id EE4C73855030 for ; Mon, 2 Aug 2021 21:19:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE4C73855030 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-uHEPudvsOp--y4ASGqYmVg-1; Mon, 02 Aug 2021 17:19:41 -0400 X-MC-Unique: uHEPudvsOp--y4ASGqYmVg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73E541008061; Mon, 2 Aug 2021 21:19:40 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6837069323; Mon, 2 Aug 2021 21:19:39 +0000 (UTC) To: Andreas Schwab Subject: Re: [PATCH 2/2] ld.so: Hide _r_debug to support DT_DEBUG [BZ #28130] References: <20210802042940.932692-1-hjl.tools@gmail.com> <20210802042940.932692-2-hjl.tools@gmail.com> <87h7g8ug94.fsf@igel.home> Date: Mon, 02 Aug 2021 23:19:37 +0200 In-Reply-To: <87h7g8ug94.fsf@igel.home> (Andreas Schwab's message of "Mon, 02 Aug 2021 15:29:27 +0200") Message-ID: <87o8afk0ie.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Andreas Schwab: > On Aug 01 2021, H.J. Lu via Libc-alpha wrote: > >> 1. Add a function, __r_debug_location, which returns the address of >> _r_debug: >> >> /* Return the address of that structure used by the dynamic linker. */ >> extern struct r_debug * __r_debug_location (void) __attribute_const__; >> >> It has a special glibc version, GLIBC_DEBUG. >> >> 2. Hide _r_debug in ld.so by defining _r_debug with __r_debug_location: >> >> #define _r_debug (*__r_debug_location ()) > > There is no need for that. Nobody should be using _r_debug. It's declared in a public header. GNAT and Spindle use it. Maybe this needs to be deprecated first before it can be removed. Thanks, Florian