From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 3/5] sysvipc: Consolidate semtimedop s390
Date: Thu, 16 May 2019 17:41:29 +0200 [thread overview]
Message-ID: <87mujms8ye.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20190516151249.19029-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Thu, 16 May 2019 12:12:47 -0300")
* Adhemerval Zanella:
> diff --git a/sysdeps/unix/sysv/linux/ipc_priv.h b/sysdeps/unix/sysv/linux/ipc_priv.h
> index 65adbb093e..49018c1b28 100644
> --- a/sysdeps/unix/sysv/linux/ipc_priv.h
> +++ b/sysdeps/unix/sysv/linux/ipc_priv.h
> @@ -34,4 +34,7 @@ struct __old_ipc_perm
> #define MSGRCV_ARGS(__msgp, __msgtyp) \
> ((long int []){ (long int) __msgp, __msgtyp })
>
> +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \
> + (__nsops), 0, (__sops), (__timeout)
Maybe add a reference to the s390 version?
> diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/ipc_priv.h b/sysdeps/unix/sysv/linux/s390/s390-32/ipc_priv.h
> new file mode 100644
> index 0000000000..9d74e92289
> +/* The s390 sys_ipc variant has only five parameters instead of six
> + (as for default variant) and the only difference is the handling of
> + SEMTIMEDOP where on s390 the third parameter is used as a pointer
> + to a struct timespec where the generic variant uses fifth parameter. */
> +#undef SEMTIMEDOP_IPC_ARGS
> +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \
> + (__nsops), (__timeout), (__sops)
I find “and the only difference is” a bit confusing here. Maybe write
“. The difference is” instead?
Rest of the patch looks okay to me.
Thanks,
Florian
next prev parent reply other threads:[~2019-05-16 15:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 15:12 [PATCH 1/5] sysvipc: Fix compat msgctl Adhemerval Zanella
2019-05-16 15:12 ` [PATCH 2/5] sysvipc: Move __IPC_64 to kernel-features.h Adhemerval Zanella
2019-05-16 15:38 ` Andreas Schwab
2019-05-16 18:57 ` Adhemerval Zanella
2019-05-20 7:42 ` Andreas Schwab
2019-05-20 11:53 ` Adhemerval Zanella
2019-05-20 12:20 ` Andreas Schwab
2019-05-20 12:30 ` Adhemerval Zanella
2019-05-20 12:38 ` Adhemerval Zanella
2019-05-16 15:12 ` [PATCH 3/5] sysvipc: Consolidate semtimedop s390 Adhemerval Zanella
2019-05-16 15:41 ` Florian Weimer [this message]
2019-05-16 19:09 ` Adhemerval Zanella
2019-05-17 9:13 ` Florian Weimer
2019-05-17 12:30 ` Adhemerval Zanella
2019-05-17 12:44 ` Florian Weimer
2019-05-17 19:09 ` Arnd Bergmann
2019-05-20 13:29 ` Adhemerval Zanella
2019-05-16 15:12 ` [PATCH 4/5] ipc: Refactor sysvipc compat type Adhemerval Zanella
2019-05-16 15:12 ` [PATCH 5/5] Update sysvipc kernel-features.h files for Linux 5.1 Adhemerval Zanella
2019-05-17 21:00 ` Stepan Golosunov
2019-05-20 12:31 ` Adhemerval Zanella
2019-05-16 15:36 ` [PATCH 1/5] sysvipc: Fix compat msgctl Florian Weimer
2019-05-16 19:06 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mujms8ye.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).