From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 989DA1F461 for ; Thu, 16 May 2019 15:41:37 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=jbFg7+rmN+xaWsOD/tYVtczTGq75jzhPa347k/zc5Rb RTlJzafvyommx2+ReJqi1rKi5+8SYNC1Lxb1T7g8uKlRy9N0NyrlY9+etSPVXYby UoYlDo+cLgGkxiGPDoJnp/5jp/VqyS+AvtO4AjQg/KxNCOYZpoZSvCwRo3sydVAM = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=/US2KL52QQWYSa6cBUXa5t/v9VQ=; b=m+6YtbjBB/Np3IcoK ycfFO3g9ggw/BcisblW8TR+yrvkC/25YncL/legcZBqxJ7JJC1Rq1TOrrwCBIdNi wPs+XE6gL33MSHZnlP4z0zBM8iltY2af3UiA2OnwhIRe4E4VighyNSi4GnbEHqAk jPfKulz3/SWgm71BmJZgHQh8S8= Received: (qmail 77546 invoked by alias); 16 May 2019 15:41:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 77534 invoked by uid 89); 16 May 2019 15:41:35 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 3/5] sysvipc: Consolidate semtimedop s390 References: <20190516151249.19029-1-adhemerval.zanella@linaro.org> <20190516151249.19029-3-adhemerval.zanella@linaro.org> Date: Thu, 16 May 2019 17:41:29 +0200 In-Reply-To: <20190516151249.19029-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Thu, 16 May 2019 12:12:47 -0300") Message-ID: <87mujms8ye.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable * Adhemerval Zanella: > diff --git a/sysdeps/unix/sysv/linux/ipc_priv.h b/sysdeps/unix/sysv/linux= /ipc_priv.h > index 65adbb093e..49018c1b28 100644 > --- a/sysdeps/unix/sysv/linux/ipc_priv.h > +++ b/sysdeps/unix/sysv/linux/ipc_priv.h > @@ -34,4 +34,7 @@ struct __old_ipc_perm > #define MSGRCV_ARGS(__msgp, __msgtyp) \ > ((long int []){ (long int) __msgp, __msgtyp }) >=20=20 > +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \ > + (__nsops), 0, (__sops), (__timeout) Maybe add a reference to the s390 version? > diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/ipc_priv.h b/sysdeps/un= ix/sysv/linux/s390/s390-32/ipc_priv.h > new file mode 100644 > index 0000000000..9d74e92289 > +/* The s390 sys_ipc variant has only five parameters instead of six > + (as for default variant) and the only difference is the handling of > + SEMTIMEDOP where on s390 the third parameter is used as a pointer > + to a struct timespec where the generic variant uses fifth parameter. = */ > +#undef SEMTIMEDOP_IPC_ARGS > +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \ > + (__nsops), (__timeout), (__sops) I find =E2=80=9Cand the only difference is=E2=80=9D a bit confusing here. = Maybe write =E2=80=9C. The difference is=E2=80=9D instead? Rest of the patch looks okay to me. Thanks, Florian