From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142)
Date: Thu, 21 Nov 2019 13:25:36 +0100 [thread overview]
Message-ID: <87lfs9o1q7.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <mvmpnhwvx68.fsf@suse.de> (Andreas Schwab's message of "Wed, 13 Nov 2019 12:21:51 +0100")
* Andreas Schwab:
> During exit, skip files that are currently locked to avoid deadlock.
Which locks are taken during the deadlock?
Does this fix or re-open bug 15142?
> + /* We want to skip locked streams. Some threads might use streams but
> + that is their problem, we don't flush those. */
> + int result = _IO_flush_all_lockp (true);
Is this still conforming to POSIX?
Sorry, it's not clear to me how this patch improves matters, and if the
direction is ultimately the right one.
Thanks,
Florian
next prev parent reply other threads:[~2019-11-21 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 11:21 [PATCH] Always do locking when accessing streams (bug 15142) Andreas Schwab
2019-11-21 12:25 ` Florian Weimer [this message]
2019-11-21 13:14 ` Andreas Schwab
2019-11-21 13:20 ` Florian Weimer
2019-11-21 13:27 ` Andreas Schwab
2019-11-25 13:30 ` Florian Weimer
2019-11-25 13:34 ` Andreas Schwab
2019-11-25 13:35 ` Florian Weimer
-- strict thread matches above, loose matches on Subject: below --
2018-01-30 16:58 Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfs9o1q7.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).