From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3B9CD1F4B5 for ; Thu, 21 Nov 2019 12:25:45 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=JJmPYDUktP0BMTRn7zHHGTKkrKT8RNAzG2bbWlTvhsL oIVploynokwfA5HWqraVNiyGFvQzqRsATy6Mvdb0zU1h1gPxN6KKUXjQXI9MQv3K DejMzfGQvRhzEYfAkrU7rmhJHr/N6quWihTTAG1fYUR57MHxVsd92no4xht1nLHs = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=jB8H+Bvs58X15LJsHENuPdYejZg=; b=IoOaRgfVGJ7iV6ESt hfFu6hd0v7GIQVZKlCjLpHAtoEXBR1gShkCX7wF5F15JtELm2cvhtNhcyQpXZpii xilcEqwUI9cH2ePgj1fYzYcuB9cm1v/hH7oQ3wg93TLWJcuRGhC0HcfL0CmbDvI3 d6t71UVjoHdvMQICiBgfv6Ewp0= Received: (qmail 62577 invoked by alias); 21 Nov 2019 12:25:43 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 62531 invoked by uid 89); 21 Nov 2019 12:25:43 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574339140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kr9mzPgRJ6s4577+uZZ59qiS1duZEAm4NlLDSDac4/I=; b=BM7AYDjwHxhN/oZJdwBuuxLKDzL8APsxiaw3+MvQ8ePaSFqhcrAye/v901Ux24y5RtfFk0 2o75GMxtaUhNJRlELZk5UAxuhnjbflSk0cB3Gs4hXXF/BVOf83ePXKs4jTzdPZmnVgEK8L LCmCaOrOx+YagYFgt1ttafugD7tVHTA= From: Florian Weimer To: Andreas Schwab Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Always do locking when accessing streams (bug 15142) References: Date: Thu, 21 Nov 2019 13:25:36 +0100 In-Reply-To: (Andreas Schwab's message of "Wed, 13 Nov 2019 12:21:51 +0100") Message-ID: <87lfs9o1q7.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable * Andreas Schwab: > During exit, skip files that are currently locked to avoid deadlock. Which locks are taken during the deadlock? Does this fix or re-open bug 15142? > + /* We want to skip locked streams. Some threads might use streams but > + that is their problem, we don't flush those. */ > + int result =3D _IO_flush_all_lockp (true); Is this still conforming to POSIX? Sorry, it's not clear to me how this patch improves matters, and if the direction is ultimately the right one. Thanks, Florian