From: Florian Weimer <fw@deneb.enyo.de>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: carlos <carlos@redhat.com>,
Joseph Myers <joseph@codesourcery.com>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [RFC PATCH glibc 12/13] support: implement xpthread key create/delete (v3)
Date: Sat, 21 Dec 2019 19:43:14 +0100 [thread overview]
Message-ID: <87imm9tt8d.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <1782942730.14629.1576953067795.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Sat, 21 Dec 2019 13:31:07 -0500 (EST)")
* Mathieu Desnoyers:
> ----- On Dec 21, 2019, at 4:51 AM, Florian Weimer fw@deneb.enyo.de wrote:
>
>> * Mathieu Desnoyers:
>>
>>> diff --git a/ChangeLog.old/ChangeLog.19 b/ChangeLog.old/ChangeLog.19
>>> index 07c6aff585..ae2e4af636 100644
>>> --- a/ChangeLog.old/ChangeLog.19
>>> +++ b/ChangeLog.old/ChangeLog.19
>>> @@ -1,3 +1,11 @@
>>> +2019-12-17 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>>> +
>>> + * support/Makefile: Add xpthread_key_create and xpthread_key_delete.
>>> + * support/xthread.h: Add prototype for xpthread_key_create and
>>> + xpthread_key_delete.
>>> + * support/xpthread_key_create.c: New file.
>>> + * support/xpthread_key_delete.c: New file.
>>> +
>>
>> Please remove the ChangeLog update. Otherwise okay.
>
> Should I remove changelog updates from all my patches ?
Yes, please. Please double-check that relevant information is
included in the commit message. But the changed entities do not need
to be listed there.
next prev parent reply other threads:[~2019-12-21 18:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 21:36 [RFC PATCH glibc 00/13] Restartable Sequences enablement Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 01/13] Introduce <elf_machine_sym_no_match.h> Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 02/13] Implement __libc_early_init Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 03/13] nptl: Start new threads with all signals blocked [BZ #25098] Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 04/13] Linux: Add tables with system call numbers Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 05/13] Linux: Use system call tables during build Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 06/13] build-many-glibcs.py: Introduce LinuxHeadersPolicyForBuild Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 07/13] build-many-glibcs.py: Introduce glibc build policy classes Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 08/13] build-many-glibcs.py: Implement update-syscalls command Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 09/13] glibc: Perform rseq(2) registration at C startup and thread creation (v13) Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 10/13] glibc: sched_getcpu(): use rseq cpu_id TLS on Linux (v5) Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 11/13] support record failure: allow use from constructor Mathieu Desnoyers
2019-12-20 21:36 ` [RFC PATCH glibc 12/13] support: implement xpthread key create/delete (v3) Mathieu Desnoyers
2019-12-21 9:51 ` Florian Weimer
2019-12-21 18:31 ` Mathieu Desnoyers
2019-12-21 18:43 ` Florian Weimer [this message]
2019-12-20 21:36 ` [RFC PATCH glibc 13/13] rseq registration tests (v7) Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2020-01-06 15:57 [RFC PATCH glibc 00/13] Restartable Sequences enablement Mathieu Desnoyers
2020-01-06 15:57 ` [RFC PATCH glibc 12/13] support: implement xpthread key create/delete (v3) Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imm9tt8d.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).