From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F3E481F463 for ; Sat, 21 Dec 2019 18:44:19 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=YPEy/ hdrj0go+C1YvbPtg+wF11pvrcfyb5XocTMfTU2uAZL1OYFdNqB7+h54fADOnOJSo FFRKTmwD8zf7ML5y296KR15wG1sWc/P1+QhpKeaBoqzNDX24Ir6ktonyioedqgO1 DBEPGT6NQCbcZhLqKsCS9c6gyouZbsP9RtsxfE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=uINz7Y1pBnu JBbWqkaw3/YYRbdU=; b=YcF+aQWvMHDJwLZlBACMH50AQoWyV5o1STkADXzC7bZ DQSOtU0qT22J0YJJr7iPAnPCQz7jEfUCMMF83lIWlCXxZFSatIVM4pMWFgqgbA4K VSinvwMnE3hJgdyDpKzdhmWPX18brrgCdXqQSCdlSo/VrPyhLGdPwh2w44ji624w = Received: (qmail 54820 invoked by alias); 21 Dec 2019 18:44:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 54808 invoked by uid 89); 21 Dec 2019 18:44:17 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: albireo.enyo.de From: Florian Weimer To: Mathieu Desnoyers Cc: carlos , Joseph Myers , Szabolcs Nagy , libc-alpha Subject: Re: [RFC PATCH glibc 12/13] support: implement xpthread key create/delete (v3) References: <20191220213650.11281-1-mathieu.desnoyers@efficios.com> <20191220213650.11281-13-mathieu.desnoyers@efficios.com> <874kxu3t2n.fsf@mid.deneb.enyo.de> <1782942730.14629.1576953067795.JavaMail.zimbra@efficios.com> Date: Sat, 21 Dec 2019 19:43:14 +0100 In-Reply-To: <1782942730.14629.1576953067795.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Sat, 21 Dec 2019 13:31:07 -0500 (EST)") Message-ID: <87imm9tt8d.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain * Mathieu Desnoyers: > ----- On Dec 21, 2019, at 4:51 AM, Florian Weimer fw@deneb.enyo.de wrote: > >> * Mathieu Desnoyers: >> >>> diff --git a/ChangeLog.old/ChangeLog.19 b/ChangeLog.old/ChangeLog.19 >>> index 07c6aff585..ae2e4af636 100644 >>> --- a/ChangeLog.old/ChangeLog.19 >>> +++ b/ChangeLog.old/ChangeLog.19 >>> @@ -1,3 +1,11 @@ >>> +2019-12-17 Mathieu Desnoyers >>> + >>> + * support/Makefile: Add xpthread_key_create and xpthread_key_delete. >>> + * support/xthread.h: Add prototype for xpthread_key_create and >>> + xpthread_key_delete. >>> + * support/xpthread_key_create.c: New file. >>> + * support/xpthread_key_delete.c: New file. >>> + >> >> Please remove the ChangeLog update. Otherwise okay. > > Should I remove changelog updates from all my patches ? Yes, please. Please double-check that relevant information is included in the commit message. But the changed entities do not need to be listed there.