From: Tulio Magno Quites Machado Filho via Libc-alpha <libc-alpha@sourceware.org>
To: Anton Blanchard <anton@ozlabs.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/3] powerpc64: Check cacheline size before using optimised memset routines
Date: Thu, 08 Jul 2021 19:33:07 -0300 [thread overview]
Message-ID: <87h7h4l9lo.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210706105107.1866836-2-anton@ozlabs.org>
Anton Blanchard via Libc-alpha <libc-alpha@sourceware.org> writes:
> A number of optimised memset routines assume the cacheline size is 128B,
> so we better check before using them.
The code looks good to me, but it's missing the same tests for bzero().
It's also important to keep sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
in sync with both functions.
Like what this patch does:
https://github.com/tuliom/glibc/commit/5b3f36c16d97db739ea5fd422d2230b4dddd2512
--
Tulio Magno
next prev parent reply other threads:[~2021-07-08 22:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 10:51 [PATCH 1/3] powerpc64: Replace some PPC_FEATURE_HAS_VSX with PPC_FEATURE_ARCH_2_06 Anton Blanchard via Libc-alpha
2021-07-06 10:51 ` [PATCH 2/3] powerpc64: Check cacheline size before using optimised memset routines Anton Blanchard via Libc-alpha
2021-07-08 22:33 ` Tulio Magno Quites Machado Filho via Libc-alpha [this message]
2021-07-06 10:51 ` [PATCH 3/3] powerpc64: Add checks for Altivec and VSX in ifunc selection Anton Blanchard via Libc-alpha
2021-07-06 15:05 ` [PATCH 1/3] powerpc64: Replace some PPC_FEATURE_HAS_VSX with PPC_FEATURE_ARCH_2_06 Adhemerval Zanella via Libc-alpha
2021-07-08 22:29 ` Tulio Magno Quites Machado Filho via Libc-alpha
2021-07-13 19:03 ` Adhemerval Zanella via Libc-alpha
2021-07-16 13:28 ` Tulio Magno Quites Machado Filho via Libc-alpha
2021-07-26 23:23 ` Anton Blanchard via Libc-alpha
-- strict thread matches above, loose matches on Subject: below --
2021-07-27 5:47 Anton Blanchard via Libc-alpha
2021-07-27 5:47 ` [PATCH 2/3] powerpc64: Check cacheline size before using optimised memset routines Anton Blanchard via Libc-alpha
2021-08-06 19:50 ` Tulio Magno Quites Machado Filho via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7h4l9lo.fsf@linux.ibm.com \
--to=libc-alpha@sourceware.org \
--cc=anton@ozlabs.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).