From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 38C271F8C6 for ; Thu, 8 Jul 2021 22:33:35 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F09C393A03F for ; Thu, 8 Jul 2021 22:33:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F09C393A03F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625783613; bh=KeQTQBQUOTR0zExocGHdL31+Lz5xT4UrJ1agaW38hE8=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=eaGlh0bgKtHYeocKmBhLGHumdwGUpnejCy9dx8G9J83mvSrnoF/Gpxz/ccS8YIL7e nSJBsV6anTJc64+5afZ6aCnRv5ZISXxG5oZDfve3j0Uf01t3eVtsNk+C8YR9TC/9QK BdGxjCvN8eSJkn6HL5V2Prqbimg+6fSSuX/bMOok= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 039B43858010 for ; Thu, 8 Jul 2021 22:33:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 039B43858010 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 168M3fhv057807; Thu, 8 Jul 2021 18:33:10 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 39nhcbj311-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Jul 2021 18:33:10 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 168MWA5H018780; Thu, 8 Jul 2021 22:33:09 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma02wdc.us.ibm.com with ESMTP id 39jfhd7bqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Jul 2021 22:33:09 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 168MX9dH9438126 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Jul 2021 22:33:09 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EFAE1112076; Thu, 8 Jul 2021 22:33:08 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82A22112071; Thu, 8 Jul 2021 22:33:08 +0000 (GMT) Received: from linux.ibm.com (unknown [9.211.47.32]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 8 Jul 2021 22:33:08 +0000 (GMT) To: Anton Blanchard Subject: Re: [PATCH 2/3] powerpc64: Check cacheline size before using optimised memset routines In-Reply-To: <20210706105107.1866836-2-anton@ozlabs.org> References: <20210706105107.1866836-1-anton@ozlabs.org> <20210706105107.1866836-2-anton@ozlabs.org> User-Agent: Notmuch/0.32.1 (http://notmuchmail.org) Emacs/27.2 (x86_64-redhat-linux-gnu) Date: Thu, 08 Jul 2021 19:33:07 -0300 Message-ID: <87h7h4l9lo.fsf@linux.ibm.com> Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: jGMkbO6dStrdqXsPJtLKAwr2iky9vUl2 X-Proofpoint-GUID: jGMkbO6dStrdqXsPJtLKAwr2iky9vUl2 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-08_12:2021-07-08, 2021-07-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 mlxlogscore=690 mlxscore=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107080113 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tulio Magno Quites Machado Filho via Libc-alpha Reply-To: Tulio Magno Quites Machado Filho Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Anton Blanchard via Libc-alpha writes: > A number of optimised memset routines assume the cacheline size is 128B, > so we better check before using them. The code looks good to me, but it's missing the same tests for bzero(). It's also important to keep sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c in sync with both functions. Like what this patch does: https://github.com/tuliom/glibc/commit/5b3f36c16d97db739ea5fd422d2230b4dddd2512 -- Tulio Magno