From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] nptl: Assume __ASSUME_FUTEX_CLOCK_REALTIME support
Date: Tue, 05 Mar 2019 12:42:19 +0100 [thread overview]
Message-ID: <87bm2pk0o4.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20190228172110.15833-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Thu, 28 Feb 2019 14:21:10 -0300")
* Adhemerval Zanella:
> This patch assumes realtime clock support for nptl and thus removes
> all the associated code.
>
> For __pthread_mutex_timedlock the fallback usage for the case where
> lll_futex_timed_wait_bitset it not set define is also removed. The
> generic lowlevellock-futex.h always define it, so for NPTL code the
> check always yield true.
>
> Checked on x86_64-linux-gnu and i686-linux-gnu.
>
> * nptl/nptl-init.c (__have_futex_clock_realtime,
> __have_futex_clock_realtime): Remove definition.
> (__pthread_initialize_minimal_internal): Remove FUTEX_CLOCK_REALTIME
> check test for !__ASSUME_FUTEX_CLOCK_REALTIME.
> * nptl/pthread_mutex_timedlock.c (__pthread_mutex_timedlock): Assume
> __ASSUME_FUTEX_CLOCK_REALTIME support.
> * sysdeps/unix/sysv/linux/i386/lowlevellock.S: Likewise.
> * sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: Likewise.
> * sysdeps/unix/sysv/linux/kernel-features.h
> (__ASSUME_FUTEX_CLOCK_REALTIME): Remove.
> * sysdeps/nptl/lowlevellock-futex.h (lll_futex_timed_wait_bitset):
> Adjust comment.
Patch looks good to me. Thanks.
Florian
prev parent reply other threads:[~2019-03-05 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 17:21 [PATCH] nptl: Assume __ASSUME_FUTEX_CLOCK_REALTIME support Adhemerval Zanella
2019-03-05 11:42 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm2pk0o4.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).