From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9544E20248 for ; Tue, 5 Mar 2019 11:42:27 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=c5ldV 74ltG5wJIgtGiIHBLgtOHweGBzwDxPPonbWpJuVqDtVVP2zb5yPlnTXSox/yinqI lQkWFjmfZQWcvu3uQm6yBKmvtdr/T3Mf2MDjqFLFQSZte+uo1X3PBaPFy2hCUQdr 4ShjVHKvmHv/laQ2s+q+h+7SFtBrN6xCWCtX/k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=PF5sD5bjTNP +BMDtwE0DSoAsyCk=; b=U7k+cZk/Bq1S1+YW0hSLd3EGI9rWkZm92y8HDsBL2gV ht9bsATGgf+JM+17qwVNSb35mmBrNYj5NYVF5giWogmic9nCMygRhwPVu8bHnUiV oQ/+WvgF/OleZgv2l3BHaUFYkHOiLmShSugeBMigE8Ypc7rGhMPt91eMswTzOvjE = Received: (qmail 89414 invoked by alias); 5 Mar 2019 11:42:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 89403 invoked by uid 89); 5 Mar 2019 11:42:24 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] nptl: Assume __ASSUME_FUTEX_CLOCK_REALTIME support References: <20190228172110.15833-1-adhemerval.zanella@linaro.org> Date: Tue, 05 Mar 2019 12:42:19 +0100 In-Reply-To: <20190228172110.15833-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Thu, 28 Feb 2019 14:21:10 -0300") Message-ID: <87bm2pk0o4.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain * Adhemerval Zanella: > This patch assumes realtime clock support for nptl and thus removes > all the associated code. > > For __pthread_mutex_timedlock the fallback usage for the case where > lll_futex_timed_wait_bitset it not set define is also removed. The > generic lowlevellock-futex.h always define it, so for NPTL code the > check always yield true. > > Checked on x86_64-linux-gnu and i686-linux-gnu. > > * nptl/nptl-init.c (__have_futex_clock_realtime, > __have_futex_clock_realtime): Remove definition. > (__pthread_initialize_minimal_internal): Remove FUTEX_CLOCK_REALTIME > check test for !__ASSUME_FUTEX_CLOCK_REALTIME. > * nptl/pthread_mutex_timedlock.c (__pthread_mutex_timedlock): Assume > __ASSUME_FUTEX_CLOCK_REALTIME support. > * sysdeps/unix/sysv/linux/i386/lowlevellock.S: Likewise. > * sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: Likewise. > * sysdeps/unix/sysv/linux/kernel-features.h > (__ASSUME_FUTEX_CLOCK_REALTIME): Remove. > * sysdeps/nptl/lowlevellock-futex.h (lll_futex_timed_wait_bitset): > Adjust comment. Patch looks good to me. Thanks. Florian