__xstat et al. as compat symbols (was: Re: [PATCH 14/16] linux: Move {f}xstat{at} to compat symbols)

[Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>]

* Adhemerval Zanella via Libc-alpha:

> diff --git a/sysdeps/unix/sysv/linux/alpha/fxstat64.c b/sysdeps/unix/sysv/linux/alpha/fxstat64.c
> index 9d6b8eca32..bcfb55050c 100644
> --- a/sysdeps/unix/sysv/linux/alpha/fxstat64.c
> +++ b/sysdeps/unix/sysv/linux/alpha/fxstat64.c
> @@ -22,9 +22,11 @@
>  #include <kernel_stat.h>
>  #include <sysdep.h>
>  #include <xstatconv.h>
> +#include <shlib-compat.h>
>  
>  /* Get information about the file NAME in BUF.  */
>  int
> +attribute_compat_text_section
>  __fxstat64 (int vers, int fd, struct stat64 *buf)
>  {
>    switch (vers)
> @@ -42,4 +44,12 @@ __fxstat64 (int vers, int fd, struct stat64 *buf)
>        }
>      }
>  }
> -strong_alias (__fxstat64, __fxstat);
> +
> +#if SHLIB_COMPAT(libc, GLIBC_2_0, GLIBC_2_33)
> +strong_alias (__fxstat64, __fxstat_compat)
> +compat_symbol (libc, __fxstat_compat, __fxstat, GLIBC_2_0);
> +#endif
> +
> +#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_33)
> +compat_symbol (libc, __fxstat64, __fxstat64, GLIBC_2_1);
> +#endif

This change breaks a lot of static libraries out there.  Do we really
want to do this immediately, or should we just stop using these symbols
from libc_nonshared.a, and defer the compat symbol treatment to a future
glibc version?

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill