From: Florian Weimer <fweimer@redhat.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Cc: Siddhesh Poyarekar <siddhesh@gotplt.org>,
"Carlos O'Donell" <codonell@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
law@redhat.com, libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] powerpc: Move cache line size to rtld_global_ro
Date: Fri, 17 Jan 2020 18:14:29 +0100 [thread overview]
Message-ID: <87a76m2efe.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <877e1qmf3a.fsf@linux.ibm.com> (Tulio Magno Quites Machado Filho's message of "Fri, 17 Jan 2020 09:39:53 -0300")
* Tulio Magno Quites Machado Filho:
> Siddhesh Poyarekar <siddhesh@gotplt.org> writes:
>
>> On 16/01/20 10:07 pm, Carlos O'Donell wrote:
>>> On 1/10/20 5:27 PM, Tulio Magno Quites Machado Filho wrote:
>>>> Changes since v1:
>>>> - Updated copyright dates
>>>> - Added tests
>>>> - Fixed coding style issues
>>>> - Added macros __GLRO_DEF and __GLRO in the 64-bit case.
>>>> - Removed sysdeps/unix/sysv/linux/powerpc/dl-support.c in favor of
>>>> sysdeps/generic/dl-auxv.h which is included by elf/dl-support.c and
>>>> elf/dl-sysdep.c
>>>> - Removed sysdeps/unix/sysv/linux/powerpc/dl-sysdep.c
>>>>
>>>
>>> OK for master. This is probably the smallest change you can make to fix
>>> all of this up.
>>>
>>> This needs approval again by Siddhesh.
>>>
>>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>>
>> This is fine.
>
> I've just pushed both patches to master.
This appears to have caused (on powerpc-linux-gnu):
../sysdeps/powerpc/powerpc32/memset.S: Assembler messages:
../sysdeps/powerpc/powerpc32/memset.S:248: Error: syntax error; found ` ', expected `,'
../sysdeps/powerpc/powerpc32/memset.S:248: Error: junk at end of line: `lwz 8,(_dl_cache_line_size+4)@l(8)'
Thanks,
Florian
next prev parent reply other threads:[~2020-01-17 17:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 1:19 powerpc build failure with GCC mainline -fno-common change Joseph Myers
2019-11-21 9:23 ` Andreas Schwab
2019-12-23 18:45 ` [PATCH] powerpc: Move cache line size to rtld_global_ro Tulio Magno Quites Machado Filho
2019-12-26 17:04 ` Adhemerval Zanella
2019-12-27 15:42 ` Tulio Magno Quites Machado Filho
2019-12-27 16:47 ` Adhemerval Zanella
2020-01-09 10:29 ` Florian Weimer
2020-01-09 16:43 ` Jeff Law
2020-01-09 17:20 ` Tulio Magno Quites Machado Filho
2020-01-09 18:03 ` Adhemerval Zanella
2020-01-09 18:49 ` Tulio Magno Quites Machado Filho
2020-01-09 18:54 ` Adhemerval Zanella
2020-01-10 22:27 ` [PATCH 1/2] powerpc: Initialize rtld_global_ro for static dlopen [BZ #20802] Tulio Magno Quites Machado Filho
2020-01-10 22:27 ` [PATCH 2/2] powerpc: Move cache line size to rtld_global_ro Tulio Magno Quites Machado Filho
2020-01-16 16:37 ` Carlos O'Donell
2020-01-17 3:56 ` Siddhesh Poyarekar
2020-01-17 12:39 ` Tulio Magno Quites Machado Filho
2020-01-17 17:14 ` Florian Weimer [this message]
2020-01-17 17:15 ` Joseph Myers
2020-01-17 22:28 ` Tulio Magno Quites Machado Filho
2020-01-17 23:45 ` [PATCH] powerpc32: Fix syntax error in __GLRO macro Andreas Schwab
2020-01-17 23:56 ` Tulio Magno Quites Machado Filho
2020-07-23 14:47 ` [PATCH 2/2] powerpc: Move cache line size to rtld_global_ro Joseph Myers
2020-07-23 16:46 ` Andreas Schwab
2020-07-31 12:42 ` Florian Weimer via Libc-alpha
2020-07-31 18:35 ` Joseph Myers
2020-08-03 8:15 ` Florian Weimer via Libc-alpha
2020-08-03 16:07 ` Carlos O'Donell via Libc-alpha
2020-01-16 16:21 ` [PATCH 1/2] powerpc: Initialize rtld_global_ro for static dlopen [BZ #20802] Carlos O'Donell
2020-01-16 16:25 ` Siddhesh Poyarekar
2020-01-09 18:56 ` [PATCH] powerpc: Move cache line size to rtld_global_ro Tulio Magno Quites Machado Filho
2020-01-10 9:38 ` Florian Weimer
2020-01-10 16:09 ` Shawn Landden
2020-01-10 18:19 ` Adhemerval Zanella
2019-11-22 16:58 ` powerpc build failure with GCC mainline -fno-common change Tulio Magno Quites Machado Filho
2019-11-23 13:23 ` Florian Weimer
2019-11-26 13:26 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a76m2efe.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=codonell@redhat.com \
--cc=law@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).