From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 161A01F466 for ; Fri, 17 Jan 2020 17:14:52 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=qMTSHhWL7JJwP71ksc4tar7zx8tU43v7hl/Ngo7xO6t 91retQqXGWfyy8PxGcoJKlS1+aUbT7QvUu+lQX0dW/048nNZTuCkYCutDjS8rsTY bu48iisIdgHfJQzHOFKH6UKlAvoJWTZXLNr+G03jszHgIIIkIzTjYnawyCq0U+nE = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type:content-transfer-encoding; s=default; bh=Jx5iUkiCHDzVAQF5joGM7aLsRHM=; b=KOOVIBTeQNseX1oQy 5KuVFeU/HkJefy1lJT4mdVFt5o5QAydQJ9/mk8Zyw/Ti6oXfWRHNU8ES95At7svN IfwTdCTzA7/TmvHiOZ8jGO+1d+qDykCthYxwHzKBfmJgDw0bKmyEF/C3rnDd5Z9j 8xIgiC57qtDy8BNmackeB5amQs= Received: (qmail 78611 invoked by alias); 17 Jan 2020 17:14:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 78594 invoked by uid 89); 17 Jan 2020 17:14:48 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579281276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KkCJbgMxfebSCAXlFxDDd00A4S4RM7/EUEtYO1xJAJU=; b=Nz9aJXfSm+ZdUyHJZ5VVpsLAW9ZQLAMd88jadF4S/ZLaQ1WrRndF/rpgdLSF/5Hc4PU+IZ aSufCtameNHybJLmntUlZr7eo287nIBNofluEKfqSjHCQnv3RgDr0xyI50DCN/6iuGS8KD LV2wWQN5qLXIAemSIz8SAYnsPAOiZpw= From: Florian Weimer To: Tulio Magno Quites Machado Filho Cc: Siddhesh Poyarekar , "Carlos O'Donell" , Adhemerval Zanella , law@redhat.com, libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] powerpc: Move cache line size to rtld_global_ro References: <1c5c49e4-55b1-a525-44a4-e2929ff1001a@linaro.org> <20200110222743.79551-1-tuliom@linux.ibm.com> <20200110222743.79551-2-tuliom@linux.ibm.com> <842602e4-fa5d-e4b8-59e7-48b2f4c9e774@redhat.com> <877e1qmf3a.fsf@linux.ibm.com> Date: Fri, 17 Jan 2020 18:14:29 +0100 In-Reply-To: <877e1qmf3a.fsf@linux.ibm.com> (Tulio Magno Quites Machado Filho's message of "Fri, 17 Jan 2020 09:39:53 -0300") Message-ID: <87a76m2efe.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * Tulio Magno Quites Machado Filho: > Siddhesh Poyarekar writes: > >> On 16/01/20 10:07 pm, Carlos O'Donell wrote: >>> On 1/10/20 5:27 PM, Tulio Magno Quites Machado Filho wrote: >>>> Changes since v1: >>>> - Updated copyright dates >>>> - Added tests >>>> - Fixed coding style issues >>>> - Added macros __GLRO_DEF and __GLRO in the 64-bit case. >>>> - Removed sysdeps/unix/sysv/linux/powerpc/dl-support.c in favor of >>>> sysdeps/generic/dl-auxv.h which is included by elf/dl-support.c and >>>> elf/dl-sysdep.c >>>> - Removed sysdeps/unix/sysv/linux/powerpc/dl-sysdep.c >>>> >>>=20 >>> OK for master. This is probably the smallest change you can make to fix >>> all of this up. >>>=20 >>> This needs approval again by Siddhesh. >>>=20 >>> Reviewed-by: Carlos O'Donell >> >> This is fine. > > I've just pushed both patches to master. This appears to have caused (on powerpc-linux-gnu): ../sysdeps/powerpc/powerpc32/memset.S: Assembler messages: ../sysdeps/powerpc/powerpc32/memset.S:248: Error: syntax error; found ` ', = expected `,' ../sysdeps/powerpc/powerpc32/memset.S:248: Error: junk at end of line: `lwz= 8,(_dl_cache_line_size+4)@l(8)' Thanks, Florian