From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Fangrui Song <maskray@google.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH 4/7] Move libc_freeres_ptrs and libc_subfreeres to weak functions
Date: Mon, 12 Dec 2022 11:58:13 +0100 [thread overview]
Message-ID: <878rjcubwa.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20221115193159.173838-5-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 15 Nov 2022 16:31:56 -0300")
* Adhemerval Zanella via Libc-alpha:
> diff --git a/elf/dl-libc.c b/elf/dl-libc.c
> index 266e068da6..06bce2f6dd 100644
> --- a/elf/dl-libc.c
> +++ b/elf/dl-libc.c
> @@ -228,7 +228,7 @@ __libc_dlclose (void *map)
> }
>
>
> -static bool __libc_freeres_fn_section
> +static bool
> free_slotinfo (struct dtv_slotinfo_list **elemp)
> {
> size_t cnt;
> @@ -256,7 +256,7 @@ free_slotinfo (struct dtv_slotinfo_list **elemp)
> }
>
>
> -libc_freeres_fn (free_mem)
> +void __libc_freemem (void)
> {
> struct link_map *l;
> struct r_search_path_elem *d;
I believe this should be called __dl_libc_freemem or something like
that, to point towards dl-libc.c as the implementing file.
Thanks,
Florian
next prev parent reply other threads:[~2022-12-12 10:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 19:31 [PATCH 0/7] Fixing remaining lld issues Adhemerval Zanella via Libc-alpha
2022-11-15 19:31 ` [PATCH 1/7] configure: Move locale tools early Adhemerval Zanella via Libc-alpha
2022-11-15 19:31 ` [PATCH 2/7] elf: Do not assume symbol order on tst-audit25{a,b} Adhemerval Zanella via Libc-alpha
2022-12-12 12:36 ` Adhemerval Zanella Netto via Libc-alpha
2022-11-15 19:31 ` [PATCH 3/7] stdlib: Move _IO_cleanup to call_function_static_weak Adhemerval Zanella via Libc-alpha
2022-12-12 10:52 ` Florian Weimer via Libc-alpha
2022-12-13 16:52 ` Joseph Myers
2022-11-15 19:31 ` [PATCH 4/7] Move libc_freeres_ptrs and libc_subfreeres to weak functions Adhemerval Zanella via Libc-alpha
2022-12-12 10:55 ` Florian Weimer via Libc-alpha
2022-12-12 13:14 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-12 10:58 ` Florian Weimer via Libc-alpha [this message]
2022-12-12 13:16 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-12 11:00 ` Florian Weimer via Libc-alpha
2022-12-12 13:49 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-12 14:05 ` Florian Weimer via Libc-alpha
2022-12-12 14:16 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-12 15:39 ` Florian Weimer via Libc-alpha
2022-12-12 11:05 ` Andreas Schwab via Libc-alpha
2022-12-12 13:49 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-12 11:08 ` Florian Weimer via Libc-alpha
2022-12-12 13:51 ` Adhemerval Zanella Netto via Libc-alpha
2022-11-15 19:31 ` [PATCH 5/7] libio: Remove the usage of __libc_IO_vtables Adhemerval Zanella via Libc-alpha
2022-12-12 11:40 ` Florian Weimer via Libc-alpha
2022-11-15 19:31 ` [PATCH 6/7] Remove --with-default-link configure option Adhemerval Zanella via Libc-alpha
2022-11-15 19:31 ` [PATCH 7/7] Remove set-hooks.h from generic includes Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjcubwa.fsf@oldenburg.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).