From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BEC491F61A for ; Mon, 12 Dec 2022 10:58:40 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="eYA4Odsm"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E93A338CC69E for ; Mon, 12 Dec 2022 10:58:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E93A338CC69E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670842719; bh=9upl0/OwU3UCaIM584JIsVdstG0PWF5wTiZQaMTYzaI=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=eYA4OdsmBY4jnQKFMMuipfF58aFtbFthTVDFoChyuH/d2c+eCJRM6/LrHKCPZQ2BY WN4zbW5O1+GSO6tjeB6gChP1Fs82fmfF1GXFlMrOv477ary5xRwqQbTqBYrTufRguC x8IOW00hYVOVmYCj5XXdoIP4VwVM24XaAPbolt2Y= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2045C3870544 for ; Mon, 12 Dec 2022 10:58:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2045C3870544 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-8n3mr6fcNUKKFvnZEqiF8A-1; Mon, 12 Dec 2022 05:58:18 -0500 X-MC-Unique: 8n3mr6fcNUKKFvnZEqiF8A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18E0C806004; Mon, 12 Dec 2022 10:58:18 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EF19492B00; Mon, 12 Dec 2022 10:58:17 +0000 (UTC) To: Adhemerval Zanella via Libc-alpha Cc: Fangrui Song , Adhemerval Zanella Subject: Re: [PATCH 4/7] Move libc_freeres_ptrs and libc_subfreeres to weak functions References: <20221115193159.173838-1-adhemerval.zanella@linaro.org> <20221115193159.173838-5-adhemerval.zanella@linaro.org> Date: Mon, 12 Dec 2022 11:58:13 +0100 In-Reply-To: <20221115193159.173838-5-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 15 Nov 2022 16:31:56 -0300") Message-ID: <878rjcubwa.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Adhemerval Zanella via Libc-alpha: > diff --git a/elf/dl-libc.c b/elf/dl-libc.c > index 266e068da6..06bce2f6dd 100644 > --- a/elf/dl-libc.c > +++ b/elf/dl-libc.c > @@ -228,7 +228,7 @@ __libc_dlclose (void *map) > } > > > -static bool __libc_freeres_fn_section > +static bool > free_slotinfo (struct dtv_slotinfo_list **elemp) > { > size_t cnt; > @@ -256,7 +256,7 @@ free_slotinfo (struct dtv_slotinfo_list **elemp) > } > > > -libc_freeres_fn (free_mem) > +void __libc_freemem (void) > { > struct link_map *l; > struct r_search_path_elem *d; I believe this should be called __dl_libc_freemem or something like that, to point towards dl-libc.c as the implementing file. Thanks, Florian