From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v7 3/8] Move malloc hooks into a compat DSO
Date: Fri, 09 Jul 2021 10:26:28 +0200 [thread overview]
Message-ID: <874kd3ki4r.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210708174325.3243721-4-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Thu, 8 Jul 2021 23:13:20 +0530")
* Siddhesh Poyarekar:
> +void (*__malloc_initialize_hook) (void) = initialize_hooks;
> +compat_symbol_reference (libc, __malloc_initialize_hook,
> + __malloc_initialize_hook, GLIBC_2_0);
This does not work on newer targets, which do not have
__malloc_initialize_hook. You need to replicate the same logic that is
used to define __malloc_initialize_hook in malloc/hooks.c (but with
OTHER_SHLIB_COMPAT).
Thanks,
Florian
next prev parent reply other threads:[~2021-07-09 8:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 17:43 [PATCH v7 0/8] malloc hooks removal Siddhesh Poyarekar via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 1/8] Remove __after_morecore_hook Siddhesh Poyarekar via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 2/8] Remove __morecore and __default_morecore Siddhesh Poyarekar via Libc-alpha
2021-07-09 6:27 ` Florian Weimer via Libc-alpha
2021-07-09 7:02 ` Siddhesh Poyarekar via Libc-alpha
2021-07-09 7:46 ` Florian Weimer via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 3/8] Move malloc hooks into a compat DSO Siddhesh Poyarekar via Libc-alpha
2021-07-09 8:08 ` Florian Weimer via Libc-alpha
2021-07-09 8:13 ` Siddhesh Poyarekar via Libc-alpha
2021-07-09 8:17 ` Florian Weimer via Libc-alpha
2021-07-09 9:17 ` Siddhesh Poyarekar via Libc-alpha
2021-07-09 9:22 ` Florian Weimer via Libc-alpha
2021-07-09 8:26 ` Florian Weimer via Libc-alpha [this message]
2021-07-09 9:21 ` Siddhesh Poyarekar via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 4/8] mcheck: Wean away from malloc hooks Siddhesh Poyarekar via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 5/8] Simplify __malloc_initialized Siddhesh Poyarekar via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 6/8] mtrace: Wean away from malloc hooks Siddhesh Poyarekar via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 7/8] glibc.malloc.check: " Siddhesh Poyarekar via Libc-alpha
2021-07-08 17:43 ` [PATCH v7 8/8] Remove " Siddhesh Poyarekar via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kd3ki4r.fsf@oldenburg.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).