From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B4A0B1F8C6 for ; Fri, 9 Jul 2021 08:26:59 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A42F3889C37 for ; Fri, 9 Jul 2021 08:26:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A42F3889C37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625819218; bh=p6Y9vubb94D78KqhBUvx1uzigO9GqdtGAemx7c29LNw=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wekly4l6A993iPqaUualsH56oK8hlot0ET7oNu+b8DomvCZbEkxx7vy9vTR+2D74l KgHbWy8imqZqKboySjjpf3X/yTRGwpqpgylgTYq7hURd5yQKSYwZTLVUwRfiOGftAm EaMZfQ/fB3FMUGwAjln0HIcJGU9/tQqFsWVtqTXw= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 200483889C21 for ; Fri, 9 Jul 2021 08:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 200483889C21 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-qVyakzfWPGKkN9wxFqSj3A-1; Fri, 09 Jul 2021 04:26:37 -0400 X-MC-Unique: qVyakzfWPGKkN9wxFqSj3A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 020C9804144; Fri, 9 Jul 2021 08:26:36 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-103.rdu2.redhat.com [10.10.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C629369A; Fri, 9 Jul 2021 08:26:30 +0000 (UTC) To: Siddhesh Poyarekar Subject: Re: [PATCH v7 3/8] Move malloc hooks into a compat DSO References: <20210708174325.3243721-1-siddhesh@sourceware.org> <20210708174325.3243721-4-siddhesh@sourceware.org> Date: Fri, 09 Jul 2021 10:26:28 +0200 In-Reply-To: <20210708174325.3243721-4-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Thu, 8 Jul 2021 23:13:20 +0530") Message-ID: <874kd3ki4r.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Siddhesh Poyarekar: > +void (*__malloc_initialize_hook) (void) = initialize_hooks; > +compat_symbol_reference (libc, __malloc_initialize_hook, > + __malloc_initialize_hook, GLIBC_2_0); This does not work on newer targets, which do not have __malloc_initialize_hook. You need to replicate the same logic that is used to define __malloc_initialize_hook in malloc/hooks.c (but with OTHER_SHLIB_COMPAT). Thanks, Florian