From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, samuel.thibault@gnu.org
Subject: Re: [PATCH htl v3 5/5] testrun.sh: Add support for --tool=rpctrace
Date: Wed, 08 Sep 2021 08:57:43 +0200 [thread overview]
Message-ID: <8735qfr1ug.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210907133325.255690-6-bugaevc@gmail.com> (Sergey Bugaev's message of "Tue, 7 Sep 2021 16:33:25 +0300")
* Sergey Bugaev:
> rpctrace(1) is a Hurd RPC tracer tool, which is used similar to how
> strace(1) is used on GNU/Linux.
>
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
> Makefile | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index f98d5a9e67..a49870d3d1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -141,8 +141,9 @@ usage () {
> cat << EOF
> Usage: $$0 [OPTIONS] <program> [ARGUMENTS...]
>
> - --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or
> - container. The container will run within support/test-container.
> + --tool=TOOL Run with the specified TOOL. It can be strace, rpctrace,
> + valgrind or container. The container will run within
> + support/test-container.
> EOF
>
> exit 1
> @@ -177,6 +178,10 @@ case "$$toolname" in
> exec strace $(patsubst %, -E%, $(run-program-env)) \
> $(test-via-rtld-prefix) $${1+"$$@"}
> ;;
> + rpctrace)
> + exec rpctrace $(patsubst %, -E%, $(run-program-env)) \
> + $(test-via-rtld-prefix) $${1+"$$@"}
> + ;;
> valgrind)
> exec env $(run-program-env) valgrind $(test-via-rtld-prefix) $${1+"$$@"}
> ;;
Looks okay. This can go in separately.
Thanks,
Florian
next prev parent reply other threads:[~2021-09-08 6:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 13:33 [PATCH htl v3 0/5] Rewrite THREAD_GSCOPE Sergey Bugaev via Libc-alpha
2021-09-07 13:33 ` [PATCH htl v3 1/5] elf: Replace most uses of THREAD_GSCOPE_IN_TCB Sergey Bugaev via Libc-alpha
2021-09-14 23:30 ` Samuel Thibault via Libc-alpha
2021-09-07 13:33 ` [PATCH htl v3 2/5] htl: Move thread table to ld.so Sergey Bugaev via Libc-alpha
2021-09-14 23:27 ` Samuel Thibault via Libc-alpha
2021-09-15 14:14 ` Sergey Bugaev via Libc-alpha
2021-09-15 14:34 ` Samuel Thibault via Libc-alpha
2021-09-15 14:35 ` Samuel Thibault via Libc-alpha
2021-09-15 15:13 ` Sergey Bugaev via Libc-alpha
2021-09-15 15:16 ` Samuel Thibault via Libc-alpha
2021-09-07 13:33 ` [PATCH htl v3 3/5] htl: Reimplement GSCOPE Sergey Bugaev via Libc-alpha
2021-09-14 23:28 ` Samuel Thibault via Libc-alpha
2021-09-07 13:33 ` [PATCH htl v3 4/5] elf: Remove THREAD_GSCOPE_IN_TCB Sergey Bugaev via Libc-alpha
2021-09-14 23:29 ` Samuel Thibault via Libc-alpha
2021-09-07 13:33 ` [PATCH htl v3 5/5] testrun.sh: Add support for --tool=rpctrace Sergey Bugaev via Libc-alpha
2021-09-08 6:57 ` Florian Weimer via Libc-alpha [this message]
2021-09-09 23:25 ` Samuel Thibault via Libc-alpha
2021-09-07 17:05 ` [PATCH htl v3 0/5] Rewrite THREAD_GSCOPE Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735qfr1ug.fsf@oldenburg.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=fweimer@redhat.com \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).