From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3B4181F8C6 for ; Wed, 8 Sep 2021 06:58:51 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB1573861800 for ; Wed, 8 Sep 2021 06:58:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB1573861800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631084329; bh=2mHj8RjBMqfVcl83oM71BUezgoXEQ1p3MNilwALFv7M=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pel2xNqyNQata7xJy7lJRMCSK+52fRVIKU+wf/aZt6Xuh7GcCIgtGsyu/nQ0osLmH w/jH4RAkuCp4qPqiBGtVOjD+GIQWYxo0Ydqyc+/C2KhbELYZXOBuWgwmc5yoZdDCre Xh2bBgBynxXknyDZUe+EOk6dRuZCbt3N1vyIvMco= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0D5FD3850419 for ; Wed, 8 Sep 2021 06:57:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D5FD3850419 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-tI3A4Y3oMaS0CPGS0BEIAQ-1; Wed, 08 Sep 2021 02:57:47 -0400 X-MC-Unique: tI3A4Y3oMaS0CPGS0BEIAQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96032801B3D; Wed, 8 Sep 2021 06:57:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.195.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FB33369A; Wed, 8 Sep 2021 06:57:45 +0000 (UTC) To: Sergey Bugaev Subject: Re: [PATCH htl v3 5/5] testrun.sh: Add support for --tool=rpctrace References: <20210907133325.255690-1-bugaevc@gmail.com> <20210907133325.255690-6-bugaevc@gmail.com> Date: Wed, 08 Sep 2021 08:57:43 +0200 In-Reply-To: <20210907133325.255690-6-bugaevc@gmail.com> (Sergey Bugaev's message of "Tue, 7 Sep 2021 16:33:25 +0300") Message-ID: <8735qfr1ug.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, samuel.thibault@gnu.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Sergey Bugaev: > rpctrace(1) is a Hurd RPC tracer tool, which is used similar to how > strace(1) is used on GNU/Linux. > > Signed-off-by: Sergey Bugaev > --- > Makefile | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index f98d5a9e67..a49870d3d1 100644 > --- a/Makefile > +++ b/Makefile > @@ -141,8 +141,9 @@ usage () { > cat << EOF > Usage: $$0 [OPTIONS] [ARGUMENTS...] > > - --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or > - container. The container will run within support/test-container. > + --tool=TOOL Run with the specified TOOL. It can be strace, rpctrace, > + valgrind or container. The container will run within > + support/test-container. > EOF > > exit 1 > @@ -177,6 +178,10 @@ case "$$toolname" in > exec strace $(patsubst %, -E%, $(run-program-env)) \ > $(test-via-rtld-prefix) $${1+"$$@"} > ;; > + rpctrace) > + exec rpctrace $(patsubst %, -E%, $(run-program-env)) \ > + $(test-via-rtld-prefix) $${1+"$$@"} > + ;; > valgrind) > exec env $(run-program-env) valgrind $(test-via-rtld-prefix) $${1+"$$@"} > ;; Looks okay. This can go in separately. Thanks, Florian