unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
To: "Adhemerval Zanella" <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org, "Vineet Gupta" <vineetg@rivosinc.com>,
	"Ludovic Courtès" <ludo@gnu.org>
Subject: Re: [PATCH 2/6] configure: Remove check if as is GNU
Date: Mon, 5 Dec 2022 10:56:13 -0500	[thread overview]
Message-ID: <7bd4e97e-7391-4f1e-9ffc-8d27765975b9@redhat.com> (raw)
In-Reply-To: <20221202190030.1671870-3-adhemerval.zanella@linaro.org>

On 12/2/22 14:00, Adhemerval Zanella via Libc-alpha wrote:
> It is not used in any place.

Good cleanup. Verified it isn't used.

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  aclocal.m4 |  6 ------
>  configure  | 20 --------------------
>  2 files changed, 26 deletions(-)
> 
> diff --git a/aclocal.m4 b/aclocal.m4
> index 531b11cb69..149b9e5376 100644
> --- a/aclocal.m4
> +++ b/aclocal.m4
> @@ -127,12 +127,6 @@ AC_SUBST(OBJCOPY)
>  GPROF=`$CC -print-prog-name=gprof`
>  AC_SUBST(GPROF)
>  
> -# Determine whether we are using GNU binutils.
> -AC_CACHE_CHECK(whether $AS is GNU as, libc_cv_prog_as_gnu,
> -[LIBC_PROG_FOO_GNU($AS, libc_cv_prog_as_gnu=yes, libc_cv_prog_as_gnu=no)])
> -rm -f a.out
> -gnu_as=$libc_cv_prog_as_gnu
> -

OK. Remove.

>  AC_CACHE_CHECK(whether $LD is GNU ld, libc_cv_prog_ld_gnu,
>  [LIBC_PROG_FOO_GNU($LD, libc_cv_prog_ld_gnu=yes, libc_cv_prog_ld_gnu=no)])
>  gnu_ld=$libc_cv_prog_ld_gnu
> diff --git a/configure b/configure
> index 9a8acc4ef7..2d3b3946b9 100755
> --- a/configure
> +++ b/configure

OK. Regenerate.

> @@ -4155,26 +4155,6 @@ OBJCOPY=`$CC -print-prog-name=objcopy`
>  GPROF=`$CC -print-prog-name=gprof`
>  
>  
> -# Determine whether we are using GNU binutils.
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $AS is GNU as" >&5
> -$as_echo_n "checking whether $AS is GNU as... " >&6; }
> -if ${libc_cv_prog_as_gnu+:} false; then :
> -  $as_echo_n "(cached) " >&6
> -else
> -  # Most GNU programs take a -v and spit out some text including
> -# the word 'GNU'.  Some try to read stdin, so give them /dev/null.
> -if $AS -o conftest -v </dev/null 2>&1 | grep GNU > /dev/null 2>&1; then
> -  libc_cv_prog_as_gnu=yes
> -else
> -  libc_cv_prog_as_gnu=no
> -fi
> -rm -fr contest*
> -fi
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_prog_as_gnu" >&5
> -$as_echo "$libc_cv_prog_as_gnu" >&6; }
> -rm -f a.out
> -gnu_as=$libc_cv_prog_as_gnu
> -
>  { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $LD is GNU ld" >&5
>  $as_echo_n "checking whether $LD is GNU ld... " >&6; }
>  if ${libc_cv_prog_ld_gnu+:} false; then :

-- 
Cheers,
Carlos.


  reply	other threads:[~2022-12-05 15:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 19:00 [PATCH 0/6] Refactor binutils configure usage Adhemerval Zanella via Libc-alpha
2022-12-02 19:00 ` [PATCH 1/6] configure: Move locale tools early Adhemerval Zanella via Libc-alpha
2022-12-05 15:56   ` Carlos O'Donell via Libc-alpha
2022-12-02 19:00 ` [PATCH 2/6] configure: Remove check if as is GNU Adhemerval Zanella via Libc-alpha
2022-12-05 15:56   ` Carlos O'Donell via Libc-alpha [this message]
2022-12-02 19:00 ` [PATCH 3/6] configure: Remove check if ld " Adhemerval Zanella via Libc-alpha
2022-12-05 15:56   ` Carlos O'Donell via Libc-alpha
2022-12-02 19:00 ` [PATCH 4/6] configure: Remove AS check Adhemerval Zanella via Libc-alpha
2022-12-05 15:56   ` Carlos O'Donell via Libc-alpha
2022-12-06 13:45   ` Andreas Schwab via Libc-alpha
2022-12-06 15:59     ` Adhemerval Zanella Netto via Libc-alpha
2022-12-02 19:00 ` [PATCH 5/6] configure: Allow user override LD, AR, OBJCOPY, and GPROF Adhemerval Zanella via Libc-alpha
2022-12-05 15:56   ` Carlos O'Donell via Libc-alpha
2022-12-07 20:04     ` Adhemerval Zanella Netto via Libc-alpha
2022-12-02 19:00 ` [PATCH 6/6] configure: Move nm, objdump, and readelf to LIBC_PROG_BINUTILS Adhemerval Zanella via Libc-alpha
2022-12-02 23:10   ` Rajalakshmi Srinivasaraghavan via Libc-alpha
2022-12-06 13:39     ` Adhemerval Zanella Netto via Libc-alpha
2022-12-05 15:57   ` Carlos O'Donell via Libc-alpha
2022-12-20 22:01 ` [PATCH 0/6] Refactor binutils configure usage Vineet Gupta
2022-12-22 12:54   ` Adhemerval Zanella Netto via Libc-alpha
2023-01-05 21:39     ` Vineet Gupta
2023-01-05 21:54       ` Adhemerval Zanella Netto via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bd4e97e-7391-4f1e-9ffc-8d27765975b9@redhat.com \
    --to=libc-alpha@sourceware.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=carlos@redhat.com \
    --cc=ludo@gnu.org \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).