From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DF32B1F601 for ; Mon, 5 Dec 2022 15:56:41 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="ckIIT3TD"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9162392AC2C for ; Mon, 5 Dec 2022 15:56:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9162392AC2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670255799; bh=/wEdwe2SejJgARabIAVKnp+1Xfl+za+Bq72PsFBM1M8=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ckIIT3TDDnqIhh68YCYHEsOCg2FAMZOJsqCGXWx3MKi9qsvwyKtjRQva+Rw3IS5PH HhDns7SgMF1Z69WvOh2NsfwjL9L9qI5PD3OFxAfLke1sEiPXKaGVM/6u/PjAzAIq/M 2dB77YGTP2N1V+3RB8Kyjdh9/7uHNLly416Hle9s= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A9237392AC02 for ; Mon, 5 Dec 2022 15:56:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A9237392AC02 Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-272-CB9JaVq5PTCqyv_XEkFyTw-1; Mon, 05 Dec 2022 10:56:16 -0500 X-MC-Unique: CB9JaVq5PTCqyv_XEkFyTw-1 Received: by mail-il1-f198.google.com with SMTP id z10-20020a921a4a000000b0030349fa9653so6113072ill.7 for ; Mon, 05 Dec 2022 07:56:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/wEdwe2SejJgARabIAVKnp+1Xfl+za+Bq72PsFBM1M8=; b=OQGGdwqKqXS3vSQqBRH2K64p8F026yFJln0qQJxWQvhg+6CYyKgmie4UWE6e4FkFCs DCLi/9Kk9EuhH6nz71RNa+TAFtOoZYhgOUX6OEH2wc7q1Si56nEnGrLMDJYb+12Ymyfu AB7A/nqG/jftnKS8IoWgIFPhG9ZWnUWwhlyC3vmyZk50q5G30CMh59Q5tJJLb+WqFO2q SKTuC9s1iU2UXpccI40HfxnrsyVyOomjkZyT8MnppmLyZGgYOaV6znUk+rRioYyz4oje ogtWyTj9Gsnak1wCq9gySXDd+BwhfZmoeu8No7Jij2NvOoN094rsgfOq6ZMAE1lxwDyX EuKA== X-Gm-Message-State: ANoB5pnrRpu8ydNHHq//zeKAKcSo1mzEp1Fg8lpDVE55AHAP7YTq1GBY RpdEppqVUmLIK7iK0q8PAhGNHuyMAJTKBRPomH2xLq1p/bnK2P3IReXW9vHqLpUBcDZ1lW5aeAv 3FprM2tmjvQ5iHbuY001a X-Received: by 2002:a05:6e02:1a8d:b0:303:2099:6370 with SMTP id k13-20020a056e021a8d00b0030320996370mr14089576ilv.82.1670255775524; Mon, 05 Dec 2022 07:56:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf5YRDRDTn+JD4Mg1LoUc1zZs/dt7BNI/SPNVxsLtD1S7okwg6Y+Es51ADlZsEyWKrN5Rg+v+w== X-Received: by 2002:a05:6e02:1a8d:b0:303:2099:6370 with SMTP id k13-20020a056e021a8d00b0030320996370mr14089563ilv.82.1670255775243; Mon, 05 Dec 2022 07:56:15 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id o15-20020a056e02092f00b00302a1848485sm443671ilt.63.2022.12.05.07.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 07:56:14 -0800 (PST) Message-ID: <7bd4e97e-7391-4f1e-9ffc-8d27765975b9@redhat.com> Date: Mon, 5 Dec 2022 10:56:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/6] configure: Remove check if as is GNU To: Adhemerval Zanella , libc-alpha@sourceware.org, Vineet Gupta , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20221202190030.1671870-1-adhemerval.zanella@linaro.org> <20221202190030.1671870-3-adhemerval.zanella@linaro.org> Organization: Red Hat In-Reply-To: <20221202190030.1671870-3-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 12/2/22 14:00, Adhemerval Zanella via Libc-alpha wrote: > It is not used in any place. Good cleanup. Verified it isn't used. LGTM. Reviewed-by: Carlos O'Donell > --- > aclocal.m4 | 6 ------ > configure | 20 -------------------- > 2 files changed, 26 deletions(-) > > diff --git a/aclocal.m4 b/aclocal.m4 > index 531b11cb69..149b9e5376 100644 > --- a/aclocal.m4 > +++ b/aclocal.m4 > @@ -127,12 +127,6 @@ AC_SUBST(OBJCOPY) > GPROF=`$CC -print-prog-name=gprof` > AC_SUBST(GPROF) > > -# Determine whether we are using GNU binutils. > -AC_CACHE_CHECK(whether $AS is GNU as, libc_cv_prog_as_gnu, > -[LIBC_PROG_FOO_GNU($AS, libc_cv_prog_as_gnu=yes, libc_cv_prog_as_gnu=no)]) > -rm -f a.out > -gnu_as=$libc_cv_prog_as_gnu > - OK. Remove. > AC_CACHE_CHECK(whether $LD is GNU ld, libc_cv_prog_ld_gnu, > [LIBC_PROG_FOO_GNU($LD, libc_cv_prog_ld_gnu=yes, libc_cv_prog_ld_gnu=no)]) > gnu_ld=$libc_cv_prog_ld_gnu > diff --git a/configure b/configure > index 9a8acc4ef7..2d3b3946b9 100755 > --- a/configure > +++ b/configure OK. Regenerate. > @@ -4155,26 +4155,6 @@ OBJCOPY=`$CC -print-prog-name=objcopy` > GPROF=`$CC -print-prog-name=gprof` > > > -# Determine whether we are using GNU binutils. > -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $AS is GNU as" >&5 > -$as_echo_n "checking whether $AS is GNU as... " >&6; } > -if ${libc_cv_prog_as_gnu+:} false; then : > - $as_echo_n "(cached) " >&6 > -else > - # Most GNU programs take a -v and spit out some text including > -# the word 'GNU'. Some try to read stdin, so give them /dev/null. > -if $AS -o conftest -v &1 | grep GNU > /dev/null 2>&1; then > - libc_cv_prog_as_gnu=yes > -else > - libc_cv_prog_as_gnu=no > -fi > -rm -fr contest* > -fi > -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_prog_as_gnu" >&5 > -$as_echo "$libc_cv_prog_as_gnu" >&6; } > -rm -f a.out > -gnu_as=$libc_cv_prog_as_gnu > - > { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $LD is GNU ld" >&5 > $as_echo_n "checking whether $LD is GNU ld... " >&6; } > if ${libc_cv_prog_ld_gnu+:} false; then : -- Cheers, Carlos.