From: Carlos O'Donell <carlos@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: Florian Weimer <fweimer@redhat.com>,
Torvald Riegel <triegel@redhat.com>,
Rik Prohaska <prohaska7@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCHv2] nptl: Fix pthread_rwlock_try*lock stalls [BZ #23844]
Date: Thu, 24 Jan 2019 20:53:39 -0500 [thread overview]
Message-ID: <7791bfbd-1bf2-a8b0-a53c-da70ef7240d3@redhat.com> (raw)
In-Reply-To: <5fb71914-ccb7-2918-9d13-5854fe98117d@gotplt.org>
On 1/24/19 8:52 PM, Siddhesh Poyarekar wrote:
> On 25/01/19 7:14 AM, Carlos O'Donell wrote:
>> On 1/22/19 1:12 PM, Carlos O'Donell wrote:
>>> v2
>>> - Added analysis comment to tryrdlock test.
>>> - Removed rw var and avoided boolean coercion.
>>> - Avoided incomplete test output to stdout.
>>
>> Siddhesh,
>>
>> Both Torvald and Rik have OK'd my use of Signed-off-by.
>>
>> Florian has done a review of tests.
>>
>> Torvald, Rik and myself have reviewed and tested the fix.
>>
>> Rik restated that the current fix I have here fixes his test case.
>>
>> I plan to do a "quick" b-m-g run to look for issues and then push
>> this fix as my last fix for 2.29.
>
> Sure, please do this before the end of the week and if anything breaks,
> revert and retry in 2.30.
Will do. In the next 24h I should have a commit or a reversion waiting
for 2.30. Thanks for the guidance.
--
Cheers,
Carlos.
prev parent reply other threads:[~2019-01-25 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 4:11 [PATCH] nptl: Fix pthread_rwlock_try*lock stalls [BZ #23844] Carlos O'Donell
2019-01-22 12:10 ` Florian Weimer
2019-01-22 18:12 ` [PATCHv2] " Carlos O'Donell
2019-01-25 1:44 ` Carlos O'Donell
2019-01-25 1:52 ` Siddhesh Poyarekar
2019-01-25 1:53 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7791bfbd-1bf2-a8b0-a53c-da70ef7240d3@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=prohaska7@gmail.com \
--cc=siddhesh@gotplt.org \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).