From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E731D1F453 for ; Fri, 25 Jan 2019 01:53:47 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=okK9fSniwhAmbwBl WnC55tBejktA55dNOERHBKjz3d2Yw71gCkSoz0FVb0sTNqePzRy+rmlO2gmTK3+p Pxr1lKF7Zb33IItEzx7sxx4dQKY7d/9/JsvGnnLQzthRwPGO6RGKTn8vmXrwOx3c qqMs2qnYJB5oQF0B2KkRvU2vj0M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=vC5VZbQEYkriKw84HJWfAj TX1mc=; b=U1fDDKtJHablyCcgCvaCjjX3EcTPIzMrlmlNoJkoPcM8w+gVu85FmS WrGLcNO2VI+y8ALxqQcW1vBj5ngSJ8gDH9+xB7qRci2VLKkWZt3nD3Rw6fCsdh7G sXRI7z9b0y9lyqKRbOmQeknWW0GgPCjzA+lvk5aJBkdiw4f71SIdU= Received: (qmail 70246 invoked by alias); 25 Jan 2019 01:53:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 70209 invoked by uid 89); 25 Jan 2019 01:53:44 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qt1-f176.google.com Subject: Re: [PATCHv2] nptl: Fix pthread_rwlock_try*lock stalls [BZ #23844] To: Siddhesh Poyarekar Cc: Florian Weimer , Torvald Riegel , Rik Prohaska , GNU C Library References: <878szcevu9.fsf@oldenburg2.str.redhat.com> <390f7db7-8e72-e718-f0eb-673eb91199c0@redhat.com> <5fb71914-ccb7-2918-9d13-5854fe98117d@gotplt.org> From: Carlos O'Donell Openpgp: preference=signencrypt Message-ID: <7791bfbd-1bf2-a8b0-a53c-da70ef7240d3@redhat.com> Date: Thu, 24 Jan 2019 20:53:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <5fb71914-ccb7-2918-9d13-5854fe98117d@gotplt.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 1/24/19 8:52 PM, Siddhesh Poyarekar wrote: > On 25/01/19 7:14 AM, Carlos O'Donell wrote: >> On 1/22/19 1:12 PM, Carlos O'Donell wrote: >>> v2 >>> - Added analysis comment to tryrdlock test. >>> - Removed rw var and avoided boolean coercion. >>> - Avoided incomplete test output to stdout. >> >> Siddhesh, >> >> Both Torvald and Rik have OK'd my use of Signed-off-by. >> >> Florian has done a review of tests. >> >> Torvald, Rik and myself have reviewed and tested the fix. >> >> Rik restated that the current fix I have here fixes his test case. >> >> I plan to do a "quick" b-m-g run to look for issues and then push >> this fix as my last fix for 2.29. > > Sure, please do this before the end of the week and if anything breaks, > revert and retry in 2.30. Will do. In the next 24h I should have a commit or a reversion waiting for 2.30. Thanks for the guidance. -- Cheers, Carlos.