From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: Update kernel-features.h files for Linux 5.1
Date: Thu, 16 May 2019 08:15:01 -0300 [thread overview]
Message-ID: <4d6d5aa8-e60b-b27d-f69f-17ae26b35bbc@linaro.org> (raw)
In-Reply-To: <CAK8P3a0XMSoByph08xy=3AOZ++XVdjLAVbYD2zaim5nTGY1OSA@mail.gmail.com>
On 16/05/2019 05:08, Arnd Bergmann wrote:
> On Fri, May 10, 2019 at 5:07 PM Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>> On 10/05/2019 07:27, Stepan Golosunov wrote:
>>> 09.05.2019 в 23:00:37 +0000 Joseph Myers написал:
>>>> Linux 5.1 adds missing syscalls to the syscall table for many Linux
>>>> kernel architectures. This patch updates the kernel-features.h
>>>> headers accordingly. I believe the statfs64 structure used by alpha
>>>> matches what the new kernel syscalls use, but that should be reviewed
>>>> carefully.
>>>>
>>>> Tested with build-many-glibcs.py.
>>>
>>> The newly added direct ipc syscalls are different from the old ones:
>>>
>>> 1. They do not accept IPC_64. This means that __IPC_64 should be set
>>> to zero when new syscalls are used. And new syscalls can not be used
>>> for compat functions like __old_semctl.
>>
>> So it seems we will need to conditionally set __IPC_64 based on kernel
>> version.
>
> How so? I did not expect to see any libc change here at all, unless
> you mean after you stop using sys_ipc().
The idea is if user configure a minimum kernel version of v5.1,
sysvipc would use wire-up syscalls. So for sys_ipc the affected
architectures calls with required IPC_64, and for wire-up syscalls
IPC_64 is redefined accordingly.
>
>> It also seems that our default value on generic ipc_priv.h
>> is not really expressing the kernel ABI.
>
> Right, it should only be set for historic ABIs.
>
>>> 2. semtimedop does not exist on 32-bit ABIs. They have
>>> semtimedop_time64 instead.
>>> (I also think that ipc with IPCOP_semtimedop was accidentally made to
>>> behave like semtimedop_time64 in 32-bit builds of linux 5.1. But that
>>> would be a kernel bug.)
>>
>> So it seems we would need to either add an __ASSUME specific for semtimedop
>> to just enable wire-up calls if time64 is defined or add another pre-processor
>> check to see if __NR_semtimeop is defined as well.
>
> The implementation I expected to see here is to have the
> 64-bit time_t version of semtimedop() to call the direct semtimedop_time64()
> system call, and fall back to the existing implementation if that
> returns -ENOSYS and the libc is built to support old kernels.
I am not taking in consideration 64-bit time_t adjustments here.
next prev parent reply other threads:[~2019-05-16 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 23:00 Update kernel-features.h files for Linux 5.1 Joseph Myers
2019-05-10 10:27 ` Stepan Golosunov
2019-05-10 13:19 ` Stepan Golosunov
2019-05-16 7:59 ` Arnd Bergmann
2019-05-16 19:41 ` Stepan Golosunov
2019-05-16 20:56 ` Arnd Bergmann
2019-05-10 15:07 ` Adhemerval Zanella
2019-05-10 15:11 ` Adhemerval Zanella
2019-05-10 16:15 ` Stepan Golosunov
2019-05-10 16:40 ` Adhemerval Zanella
2019-05-16 8:08 ` Arnd Bergmann
2019-05-16 11:15 ` Adhemerval Zanella [this message]
2019-05-16 11:34 ` Arnd Bergmann
2019-05-16 12:28 ` Adhemerval Zanella
2019-05-16 12:42 ` Arnd Bergmann
2019-05-13 21:33 ` Joseph Myers
2019-05-16 15:06 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6d5aa8-e60b-b27d-f69f-17ae26b35bbc@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).