unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Stepan Golosunov <stepan@golosunov.pp.ru>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: Update kernel-features.h files for Linux 5.1
Date: Thu, 16 May 2019 23:41:47 +0400	[thread overview]
Message-ID: <20190516194147.b662wrsv4jco3wt6@sghpc.golosunov.pp.ru> (raw)
In-Reply-To: <CAK8P3a2ZRZrjwDb=YzTVGpm5ZFaz55jckK-Z2qAwWvj-k5qS_A@mail.gmail.com>

16.05.2019 в 09:59:40 +0200 Arnd Bergmann написал:
> On Fri, May 10, 2019 at 3:19 PM Stepan Golosunov <stepan@golosunov.pp.ru> wrote:
> > > (I also think that ipc with IPCOP_semtimedop was accidentally made to
> > > behave like semtimedop_time64 in 32-bit builds of linux 5.1.  But that
> > > would be a kernel bug.)
> 
> Can you elaborate? The code I see in mainline is
> 
>         case SEMTIMEDOP:
>                 if (IS_ENABLED(CONFIG_64BIT) || !IS_ENABLED(CONFIG_64BIT_TIME))
>                         return ksys_semtimedop(first, ptr, second,
>                                 (const struct __kernel_timespec __user *)fifth);
>                 else if (IS_ENABLED(CONFIG_COMPAT_32BIT_TIME))
>                         return compat_ksys_semtimedop(first, ptr, second,
>                                 (const struct old_timespec32 __user *)fifth);
>                 else
>                         return -ENOSYS;
> 
> Since both CONFIG_64BIT_TIME and CONFIG_COMPAT_32BIT_TIME
> are always set on 32-bit architectures, SEMTIMEDOP passes
> an old_timespec32 argument here. Am I missing something?

If CONFIG_64BIT_TIME is set then there is no problem.  But I do not
see where it is set.  (The patch to set it to y was merged only now
and is not in 5.1.)  And if it's not set, then ipc and socketcall are
broken.

  reply	other threads:[~2019-05-16 19:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 23:00 Update kernel-features.h files for Linux 5.1 Joseph Myers
2019-05-10 10:27 ` Stepan Golosunov
2019-05-10 13:19   ` Stepan Golosunov
2019-05-16  7:59     ` Arnd Bergmann
2019-05-16 19:41       ` Stepan Golosunov [this message]
2019-05-16 20:56         ` Arnd Bergmann
2019-05-10 15:07   ` Adhemerval Zanella
2019-05-10 15:11     ` Adhemerval Zanella
2019-05-10 16:15       ` Stepan Golosunov
2019-05-10 16:40         ` Adhemerval Zanella
2019-05-16  8:08     ` Arnd Bergmann
2019-05-16 11:15       ` Adhemerval Zanella
2019-05-16 11:34         ` Arnd Bergmann
2019-05-16 12:28           ` Adhemerval Zanella
2019-05-16 12:42             ` Arnd Bergmann
2019-05-13 21:33   ` Joseph Myers
2019-05-16 15:06     ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516194147.b662wrsv4jco3wt6@sghpc.golosunov.pp.ru \
    --to=stepan@golosunov.pp.ru \
    --cc=arnd@arndb.de \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).