* Use libc_hidden_* for tolower, toupper (bug 15105)
@ 2018-02-22 21:24 Joseph Myers
2018-02-23 8:58 ` Florian Weimer
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Myers @ 2018-02-22 21:24 UTC (permalink / raw)
To: libc-alpha
Continuing the fixes for localplt test failures with -Os arising from
functions not being inlined in that case, this patch fixes such
failures for tolower and toupper by using libc_hidden_proto and
libc_hidden_def.
Tested for x86_64 (both that it removes this particular localplt
failure for -Os, and that the testsuite continues to pass without
-Os). Together with my patch
<https://sourceware.org/ml/libc-alpha/2018-02/msg00602.html> for atoi
(pending review), this completes fixing such localplt failures for -Os
(at least for x86_64).
2018-02-22 Joseph Myers <joseph@codesourcery.com>
[BZ #15105]
* ctype/ctype.c (tolower): Use libc_hidden_def.
(toupper): Likewise.
* include/ctype.h [!_ISOMAC] (tolower): Use libc_hidden_proto.
[!_ISOMAC] (toupper): Likewise.
diff --git a/ctype/ctype.c b/ctype/ctype.c
index e86c5b0..6cb8000 100644
--- a/ctype/ctype.c
+++ b/ctype/ctype.c
@@ -45,9 +45,11 @@ tolower (int c)
{
return c >= -128 && c < 256 ? __ctype_tolower[c] : c;
}
+libc_hidden_def (tolower)
int
toupper (int c)
{
return c >= -128 && c < 256 ? __ctype_toupper[c] : c;
}
+libc_hidden_def (toupper)
diff --git a/include/ctype.h b/include/ctype.h
index ac6db79..493a6f8 100644
--- a/include/ctype.h
+++ b/include/ctype.h
@@ -11,6 +11,9 @@ libc_hidden_proto (__ctype_init)
So defeat macro expansion with parens for this declaration. */
extern int (__isctype) (int __c, int __mask);
+libc_hidden_proto (tolower)
+libc_hidden_proto (toupper)
+
# if IS_IN (libc)
/* These accessors are used by the optimized macros to find the
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Use libc_hidden_* for tolower, toupper (bug 15105)
2018-02-22 21:24 Use libc_hidden_* for tolower, toupper (bug 15105) Joseph Myers
@ 2018-02-23 8:58 ` Florian Weimer
0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2018-02-23 8:58 UTC (permalink / raw)
To: Joseph Myers, libc-alpha
On 02/22/2018 10:24 PM, Joseph Myers wrote:
> 2018-02-22 Joseph Myers<joseph@codesourcery.com>
>
> [BZ #15105]
> * ctype/ctype.c (tolower): Use libc_hidden_def.
> (toupper): Likewise.
> * include/ctype.h [!_ISOMAC] (tolower): Use libc_hidden_proto.
> [!_ISOMAC] (toupper): Likewise.
Looks good.
Thanks,
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-23 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 21:24 Use libc_hidden_* for tolower, toupper (bug 15105) Joseph Myers
2018-02-23 8:58 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).