* [PATCH v2] <time.h>: Make strptime available by default
@ 2022-11-28 14:49 Florian Weimer via Libc-alpha
2022-12-08 17:13 ` Adhemerval Zanella Netto via Libc-alpha
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer via Libc-alpha @ 2022-11-28 14:49 UTC (permalink / raw)
To: libc-alpha
This matches what FreeBSD does.
---
v2: Remove unneccesary parentheses.
time/time.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/time/time.h b/time/time.h
index d18089116e..0919e578d4 100644
--- a/time/time.h
+++ b/time/time.h
@@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize,
const char *__restrict __format,
const struct tm *__restrict __tp) __THROW;
-#ifdef __USE_XOPEN
+#if defined __USE_XOPEN || defined __USE_MISC
/* Parse S according to FORMAT and store binary time information in TP.
The return value is a pointer to the first unparsed character in S. */
extern char *strptime (const char *__restrict __s,
base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] <time.h>: Make strptime available by default
2022-11-28 14:49 [PATCH v2] <time.h>: Make strptime available by default Florian Weimer via Libc-alpha
@ 2022-12-08 17:13 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-08 18:13 ` Florian Weimer via Libc-alpha
0 siblings, 1 reply; 4+ messages in thread
From: Adhemerval Zanella Netto via Libc-alpha @ 2022-12-08 17:13 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote:
> This matches what FreeBSD does.
>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> v2: Remove unneccesary parentheses.
> time/time.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/time/time.h b/time/time.h
> index d18089116e..0919e578d4 100644
> --- a/time/time.h
> +++ b/time/time.h
> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize,
> const char *__restrict __format,
> const struct tm *__restrict __tp) __THROW;
>
> -#ifdef __USE_XOPEN
> +#if defined __USE_XOPEN || defined __USE_MISC
> /* Parse S according to FORMAT and store binary time information in TP.
> The return value is a pointer to the first unparsed character in S. */
> extern char *strptime (const char *__restrict __s,
>
> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] <time.h>: Make strptime available by default
2022-12-08 17:13 ` Adhemerval Zanella Netto via Libc-alpha
@ 2022-12-08 18:13 ` Florian Weimer via Libc-alpha
2022-12-08 18:24 ` Adhemerval Zanella Netto via Libc-alpha
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer via Libc-alpha @ 2022-12-08 18:13 UTC (permalink / raw)
To: Adhemerval Zanella Netto; +Cc: libc-alpha
* Adhemerval Zanella Netto:
> On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote:
>> This matches what FreeBSD does.
>>
>
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
>> ---
>> v2: Remove unneccesary parentheses.
>> time/time.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/time/time.h b/time/time.h
>> index d18089116e..0919e578d4 100644
>> --- a/time/time.h
>> +++ b/time/time.h
>> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize,
>> const char *__restrict __format,
>> const struct tm *__restrict __tp) __THROW;
>>
>> -#ifdef __USE_XOPEN
>> +#if defined __USE_XOPEN || defined __USE_MISC
>> /* Parse S according to FORMAT and store binary time information in TP.
>> The return value is a pointer to the first unparsed character in S. */
>> extern char *strptime (const char *__restrict __s,
>>
>> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d
>>
I think this change has been vetoed by Andreas. I assume he wants us to
define __USE_XOPEN by default to check all visiblities at once.
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] <time.h>: Make strptime available by default
2022-12-08 18:13 ` Florian Weimer via Libc-alpha
@ 2022-12-08 18:24 ` Adhemerval Zanella Netto via Libc-alpha
0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella Netto via Libc-alpha @ 2022-12-08 18:24 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 08/12/22 15:13, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
>
>> On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote:
>>> This matches what FreeBSD does.
>>>
>>
>>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>>
>>> ---
>>> v2: Remove unneccesary parentheses.
>>> time/time.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/time/time.h b/time/time.h
>>> index d18089116e..0919e578d4 100644
>>> --- a/time/time.h
>>> +++ b/time/time.h
>>> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize,
>>> const char *__restrict __format,
>>> const struct tm *__restrict __tp) __THROW;
>>>
>>> -#ifdef __USE_XOPEN
>>> +#if defined __USE_XOPEN || defined __USE_MISC
>>> /* Parse S according to FORMAT and store binary time information in TP.
>>> The return value is a pointer to the first unparsed character in S. */
>>> extern char *strptime (const char *__restrict __s,
>>>
>>> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d
>>>
>
> I think this change has been vetoed by Andreas. I assume he wants us to
> define __USE_XOPEN by default to check all visiblities at once.
>
> Florian
>
Alright then, defining __USE_XOPEN works as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-08 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 14:49 [PATCH v2] <time.h>: Make strptime available by default Florian Weimer via Libc-alpha
2022-12-08 17:13 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-08 18:13 ` Florian Weimer via Libc-alpha
2022-12-08 18:24 ` Adhemerval Zanella Netto via Libc-alpha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).