From: Rich Felker <dalias@libc.org>
To: Gabriel Ravier <gabravier@gmail.com>
Cc: "Skyler Ferrante (RIT Student)" <sjf5462@rit.edu>,
Andreas Schwab <schwab@suse.de>,
Alejandro Colomar <alx@kernel.org>,
Thorsten Glaser <tg@mirbsd.de>,
musl@lists.openwall.com, NRK <nrk@disroot.org>,
Guillem Jover <guillem@hadrons.org>,
libc-alpha@sourceware.org, libbsd@lists.freedesktop.org,
"Serge E. Hallyn" <serge@hallyn.com>,
Iker Pedrosa <ipedrosa@redhat.com>,
Christian Brauner <christian@brauner.io>
Subject: Re: [musl] Re: Tweaking the program name for <err.h> functions
Date: Mon, 11 Mar 2024 20:43:09 -0400 [thread overview]
Message-ID: <20240312004309.GZ4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <40962405-c5b4-4925-9ca5-7a1c723ebbfd@gmail.com>
On Tue, Mar 12, 2024 at 12:18:24AM +0000, Gabriel Ravier wrote:
> On 3/11/24 19:47, Rich Felker wrote:
> >On Mon, Mar 11, 2024 at 11:30:04AM -0400, Skyler Ferrante (RIT Student) wrote:
> >>Hmm, maybe I'm missing something, but it seems you can close(fd) for
> >>the standard fds and then call execve, and the new process image will
> >>have no fd 0,1,2. I've tried this on a default Ubuntu 22.04 system.
> >>This seems to affect shadow-utils and other setuid/setgid binaries.
> >>
> >>Here is a repo I built for testing,
> >>https://github.com/skyler-ferrante/fd_omission/. What is the correct
> >>glibc behavior? Am I misunderstanding something?
> >As Florian noted, you're missing that strace cannot invoke it suid.
> >POSIX explicitly permits the implementation to open these fds if they
> >started closed in suid execs, and IIRC indicates as a future direction
> >that it might be permitted for all execs. We do the same in musl in
> >the suid case. So really the only way that "writing attacker
> >controlled prefix strings to fd 2" becomes an issue is if the
> >application erroneously closes fd 2 and lets something else get opened
> >on it.
> >
> >(Aside: making _FORTIFY_SOURCE>1 trap close(n) with n<3 would be an
> >interesting idea... :)
>
> Doing this would break many programs, such as:
> - most of coreutils, e.g. programs like ls, cat or head, since they
> always `close` their input and output descriptors (when they've
> written or read something) to make sure to diagnose all errors
> - grep
> - xargs
> - find
This makes it so they can malfunction during exit when it
flushes/closes the corresponding stdio FILEs. If nothing else has been
opened in the mean time, under typical implementations it should be
safe, but I think per 2.5.1 Interaction of File Descriptors and
Standard I/O Streams:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_05_01
it's undefined.
The safe way to do what they want is to dup the fd they want to
close-and-check-for-errors, open /dev/null, dup2 that over the
original fd, then close the first dup.
Or, don't exit()/return-from-main, but instead _exit, so there's no
subsequent access to the FILE.
> - strace, which (using the half-closed self-pipe trick mentioned
> earlier in this thread to avoid reusing them later btw) closes the
> standard descriptors, to avoid changing the behavior of programs
> calling it if e.g. its input is a pipe (where if it left the fds
> open that'd mean the writer would get SIGPIPE later than if the
> program was ran without strace)
> - tcsh, which deliberately does `close(n)` with `n < 3` to make it
> so all the standard FDs point to `/dev/null`
> - troff and groff (and thus man)
> - git
> - many more... I have found these by simply stracing random programs
> as found on my system with `ls /bin/ | shuf -n1`
Yes, I'm quite aware it's commonplace, but it would be something nice
to get cleaned up...
Rich
next prev parent reply other threads:[~2024-03-12 0:43 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 22:24 Tweaking the program name for <err.h> functions Alejandro Colomar
2024-03-08 0:30 ` Guillem Jover
2024-03-08 0:47 ` enh
2024-03-08 0:52 ` Alejandro Colomar
2024-03-09 15:02 ` [musl] " Rich Felker
2024-03-09 15:49 ` Alejandro Colomar
2024-03-09 18:35 ` Andreas Schwab
2024-03-09 18:46 ` Alejandro Colomar
2024-03-09 19:18 ` [musl] " Markus Wichmann
2024-03-09 19:25 ` Rich Felker
2024-03-09 21:44 ` Thorsten Glaser
2024-03-10 6:01 ` NRK
2024-03-10 13:17 ` Alejandro Colomar
2024-03-10 14:01 ` NRK
2024-03-10 19:39 ` Rich Felker
2024-03-10 22:25 ` Alejandro Colomar
2024-03-10 23:22 ` Thorsten Glaser
2024-03-10 23:44 ` Rich Felker
2024-03-11 0:19 ` Thorsten Glaser
2024-03-11 0:46 ` Alejandro Colomar
2024-03-11 14:46 ` Skyler Ferrante (RIT Student)
2024-03-11 15:09 ` Andreas Schwab
2024-03-11 15:30 ` Skyler Ferrante (RIT Student)
2024-03-11 18:23 ` Florian Weimer
2024-03-11 18:48 ` Skyler Ferrante (RIT Student)
2024-03-11 19:05 ` enh
2024-03-11 19:44 ` Rich Felker
2024-03-11 20:35 ` enh
2024-03-11 19:47 ` Rich Felker
2024-03-11 20:08 ` Skyler Ferrante (RIT Student)
2024-03-11 20:39 ` enh
2024-03-11 21:21 ` Laurent Bercot
2024-03-11 22:05 ` Thorsten Glaser
2024-03-12 0:18 ` Gabriel Ravier
2024-03-12 0:43 ` Rich Felker [this message]
2024-03-12 3:23 ` Gabriel Ravier
2024-03-12 14:44 ` Rich Felker
2024-03-12 13:54 ` Florian Weimer
2024-03-12 14:21 ` Zack Weinberg
2024-03-12 14:31 ` Florian Weimer
2024-03-12 14:42 ` Rich Felker
2024-03-12 19:25 ` Zack Weinberg
2024-03-12 21:19 ` Rich Felker
2024-03-13 8:28 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312004309.GZ4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=alx@kernel.org \
--cc=christian@brauner.io \
--cc=gabravier@gmail.com \
--cc=guillem@hadrons.org \
--cc=ipedrosa@redhat.com \
--cc=libbsd@lists.freedesktop.org \
--cc=libc-alpha@sourceware.org \
--cc=musl@lists.openwall.com \
--cc=nrk@disroot.org \
--cc=schwab@suse.de \
--cc=serge@hallyn.com \
--cc=sjf5462@rit.edu \
--cc=tg@mirbsd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).