Re: [PATCH v2] io: Refactor close_range and closefrom

[Samuel Thibault via Libc-alpha <libc-alpha@sourceware.org>]

Florian Weimer, le mer. 24 nov. 2021 13:03:19 +0100, a ecrit:
> * Adhemerval Zanella:
> 
> >> diff --git a/sysdeps/mach/hurd/kernel-features.h b/sysdeps/mach/hurd/kernel-features.h
> >> index 7d4eaee0a6..5fd37a6d7b 100644
> >> --- a/sysdeps/mach/hurd/kernel-features.h
> >> +++ b/sysdeps/mach/hurd/kernel-features.h
> >> @@ -19,3 +19,5 @@
> >>  /* This file can define __ASSUME_* macros checked by certain source files.
> >>     Almost none of these are used outside of sysdeps/unix/sysv/linux code.
> >>     But those referring to POSIX-level features like O_* flags can be.  */
> >> +
> >> +#define __ASSUME_CLOSE_RANGE 1
> >
> > It does add it here (I also checked with a build for i688-gnu).
> 
> Hmm, this doesn't match existing practice.  We haven't unified
> implementations in light of such divergence, I think.  If the Hurd
> developers don't object, it should be fine, though..

I'm fine with it yes. This is not a "kernel-feature" since it's actually
implemented inside glibc itself, but from the point of view of the rest
of the world that's how people understand it, so better adhere to it :)

Samuel