From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E0DC21F953 for ; Wed, 24 Nov 2021 12:18:03 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A09943857830 for ; Wed, 24 Nov 2021 12:18:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A09943857830 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637756282; bh=tw86JSocDj3URJHIMS5SviyhGq1BCmjul20JfOzUEfw=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OS1rcs/5Uy3N0ULtEErxPZOWswZ8NeJldgN5enRrHsZZWjxpkMPCvjdY9ypYoPDeL DGx7o36S9JdRQla0Ln1xZz0zHmw4vQGOXG5aB/LGq7gwm6onDZA/TeBB6KlNmvTM69 5EfrmBDXFNcr1Qr0ZjFmjfAq8ZElGqz5jhQzX4zs= Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sourceware.org (Postfix) with ESMTPS id 1BE0C385842B for ; Wed, 24 Nov 2021 12:17:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BE0C385842B IronPort-HdrOrdr: =?us-ascii?q?A9a23=3ANX/NL659iDlbngPqBwPXwPfXdLJyesId70hD?= =?us-ascii?q?6qm+c20tTiX4rbHXoB1/73XJYVkqKRQdcLy7Scu9qDbnhP1ICOoqXItKPjOW3F?= =?us-ascii?q?dARbsKheDfKn/bexEWndQtspuIHZIObuEYzmIXsS852mSF+hobr+VvOZrHudvj?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="400160744" Received: from nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr (HELO begin) ([194.199.1.52]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Nov 2021 13:17:41 +0100 Received: from samy by begin with local (Exim 4.95) (envelope-from ) id 1mprDZ-005WQY-32; Wed, 24 Nov 2021 13:17:41 +0100 Date: Wed, 24 Nov 2021 13:17:41 +0100 To: Florian Weimer Subject: Re: [PATCH v2] io: Refactor close_range and closefrom Message-ID: <20211124121741.qcrchlkne6c3ystm@begin> References: <20211108172817.2235239-1-adhemerval.zanella@linaro.org> <87r1b5op82.fsf@oldenburg.str.redhat.com> <87mtltoj5k.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mtltoj5k.fsf@oldenburg.str.redhat.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Samuel Thibault via Libc-alpha Reply-To: Samuel Thibault Cc: Adhemerval Zanella via Libc-alpha , Sergey Bugaev Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Florian Weimer, le mer. 24 nov. 2021 13:03:19 +0100, a ecrit: > * Adhemerval Zanella: > > >> diff --git a/sysdeps/mach/hurd/kernel-features.h b/sysdeps/mach/hurd/kernel-features.h > >> index 7d4eaee0a6..5fd37a6d7b 100644 > >> --- a/sysdeps/mach/hurd/kernel-features.h > >> +++ b/sysdeps/mach/hurd/kernel-features.h > >> @@ -19,3 +19,5 @@ > >> /* This file can define __ASSUME_* macros checked by certain source files. > >> Almost none of these are used outside of sysdeps/unix/sysv/linux code. > >> But those referring to POSIX-level features like O_* flags can be. */ > >> + > >> +#define __ASSUME_CLOSE_RANGE 1 > > > > It does add it here (I also checked with a build for i688-gnu). > > Hmm, this doesn't match existing practice. We haven't unified > implementations in light of such divergence, I think. If the Hurd > developers don't object, it should be fine, though.. I'm fine with it yes. This is not a "kernel-feature" since it's actually implemented inside glibc itself, but from the point of view of the rest of the world that's how people understand it, so better adhere to it :) Samuel