Re: [PATCH v2] aarch64: Skip traditional GD/LD TLS which are unsupported by Clang and LLD [BZ #28205]

[Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>]

The 08/10/2021 14:14, Fangrui Song via Libc-alpha wrote:
> On 2021-08-10, Fangrui Song wrote:
> > TLSDESC is the default on aarch64.  Clang doesn't support
> > -mtls-dialect=trad.  Its integrated assembler doesn't support the
> > marker.  LLD's doesn't support R_AARCH64_TLSGD_*/R_AARCH64_TLSLD_*
> > relocations.  Just skip the tests.
> > 
> > With https://sourceware.org/pipermail/libc-alpha/2021-August/129966.html
> > ("aarch64: Make elf_machine_{load_address, dynamic} robust [BZ #28203]"),
> > if we allow LLD in configure.ac,
> > `make check` test results of LLD are on par with GNU ld.
> 
> I messed up in the diff.
> The correct diff needs `#include <config.h>` to make HAVE_TRAD_TLS
> defined.

the fixed patch looks good to me.

but now i looked at elf/tls-macros.h and it seems
to be for when there is on compiler support.

i think the only thing the compiler does not
support is mixing different tls access models to a
variable in the same tu, but i'm not sure if that's
useful or necessary for the tests: we can use many
files with different -ftls-model= or
__attribute__((tls_model(...))).

is there a need for these hard to maintain macros?