From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 91AFF1F8C6 for ; Wed, 11 Aug 2021 12:18:28 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE00D39730CF for ; Wed, 11 Aug 2021 12:18:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE00D39730CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628684306; bh=yDWlzqbwPiiVRfOyrbc7uR8L6L6X81bDmGC/RdtXZCo=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MYDShYLF8o8Zeu5/grR9F3U97gC9KWL7OoC5PVU5d504Al4zfeXbdP/eXzfRYW+2E B5fv7eWm7Mq3MmAq5WsiJVZv1Z8MU9tC5AHWylemnzxRmQnQ/+y4fuO6+JmuCGglQI rLNO2spyR64B0Wr3hxiLxAP2IXkr9QHw3QTJRhg0= Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00089.outbound.protection.outlook.com [40.107.0.89]) by sourceware.org (Postfix) with ESMTPS id 5694E397EC07 for ; Wed, 11 Aug 2021 12:17:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5694E397EC07 Received: from AM5PR0301CA0030.eurprd03.prod.outlook.com (2603:10a6:206:14::43) by DB8PR08MB5194.eurprd08.prod.outlook.com (2603:10a6:10:e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.17; Wed, 11 Aug 2021 12:17:54 +0000 Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::1e) by AM5PR0301CA0030.outlook.office365.com (2603:10a6:206:14::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Wed, 11 Aug 2021 12:17:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Wed, 11 Aug 2021 12:17:53 +0000 Received: ("Tessian outbound 8529ae990a93:v101"); Wed, 11 Aug 2021 12:17:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 890c805cbf100b7b X-CR-MTA-TID: 64aa7808 Received: from 4d4443bd2e49.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52A4695B-C805-4659-A1B3-654B077AF1AF.1; Wed, 11 Aug 2021 12:17:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d4443bd2e49.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Aug 2021 12:17:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JWn5Xn7l4/06Wc6jVvRY96F1ifgAP/UqZBdFtPjJ9+DrMxJau1BsAK7KXevpB/5J6k3GDlnEEAiBv5dSSU3XJ/PNeXHqkSp8w/I2dbuAzqRZLQ7p2pc/ya+kf3DsCauxX6M2SCUrPjgqm+cTKBl8KrskFeeHW6OOMpobLbJpEUMeyeg9ahhKBoofEeyKaWMISdbb89MI2pTJ9wa99ALbhJcEcrJIjgRsUQbUzQ+NJyLHHNs8RuIu1SF4TiLF5VMw834gfoBNV4Ffg8grCpHTeHMi3cruKMBi6f9OSGpX72RLNA+JWM5OehoCBxvp0VrWxttolqtv2V6hg9dqo0OJUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yDWlzqbwPiiVRfOyrbc7uR8L6L6X81bDmGC/RdtXZCo=; b=nozAfvNFMQt+5fNsT6NrVQnhcc23NHWygCeSz7cQeh0oCkIT0nHY5YFLLfrIJD8/psSHyunj0RSSw+QnNhpK6W+WBomqHWWdyrm/fBnTwd6230C1OP8z+C/BZTZZ4cH1aqW1l7kiY+6OZZWdDyGmiYjt9GrYHCObkmbaaNYbFKNCmWOZziGGkQGzXTklyJpMLEl/5qOrMH5OZa6AtC2dNEQ0dD+TZ9xQbqMVVgm402GM9R0F4TtGfoUEi9CstMotdFmz6wjM3mt870zmLFNZ+6FG4umVZw3gdozwxDURifqQjfPqnMoTDjmwfbwHYkvt4qXSuy0A57sgMlWXjaUg2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PAXPR08MB6847.eurprd08.prod.outlook.com (2603:10a6:102:13d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13; Wed, 11 Aug 2021 12:17:44 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::cd22:a583:c97c:72a6]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::cd22:a583:c97c:72a6%7]) with mapi id 15.20.4415.013; Wed, 11 Aug 2021 12:17:44 +0000 Date: Wed, 11 Aug 2021 13:17:42 +0100 To: Fangrui Song Subject: Re: [PATCH v2] aarch64: Skip traditional GD/LD TLS which are unsupported by Clang and LLD [BZ #28205] Message-ID: <20210811121740.GL20410@arm.com> References: <20210810210247.676100-1-maskray@google.com> <20210810211458.oxx3t5phzt3z3sp3@google.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210810211458.oxx3t5phzt3z3sp3@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: LO4P123CA0371.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::16) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.49) by LO4P123CA0371.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Wed, 11 Aug 2021 12:17:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee0fee6f-346c-4681-2a14-08d95cc20b85 X-MS-TrafficTypeDiagnostic: PAXPR08MB6847:|DB8PR08MB5194: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: W7ad+Zbs4+sORsxErULbA7JX3gXvjnQyyuzKZ4cLycqOJHbIneSkEucT/cacYDESaqF/mmnApCEPNrKS4iJTEbcN55cFGdplmYn29QLyO6GGVUF9ULDSeypjwMUsP49Ei1VOlzR3Cax2qeIPC4BBrbNRbFn1NdZCNhsw+r2B7N3MQcplCpGCYJvCCMTYsiUHrwjxrYvDeqw1UN0SNvM5QctrOY+w1G/8TkmtJF3lkWorTqlkdV+t98oQycpfionhK/Bny1xBNMjHubqooCID8TWnEv5dcyKBloxpRudumZDdq8PYJVND16AzNcduVOOtmLyWCodKeN8vzlXONtYF2OvLrX66YUeAM8LuM+glIhBjtDlft1dP3ncDKPc5sgtllCnDEjpXjuS3mt9g1+jxoDJBdR8NdaOYKU8EnEQ+ryODTIcamalNVPd/vj18zCPjCbfrKUD9Hr+VP0A1UFSD4E5ZFZaXb8BgV3BYDaGhIUqiXZnUyEe0JST5i6JXBnlnk/IbAQAOlw+t4XGnB6Gr79NaOyDNO2s1p4LK4H/gmqi9qILnUW3k95OKOQlgWXxtR28fhOaLmFBuYnO3X5sVcFC770xzpUfZ5Tve2b/NY7OCg9nMGw0kEGychBwDA+gXeBM9bfYRjuJB+dpy9Ck93Xt/UvRM4L+uJ1pBCzJ0y4CqxSTqxg10obOwv1+IfKwvj/RWiKoIIM2X/y4W9omDUHpPmfbgGW//R7L6bLd8+D8tT5TN4mZAxp3sVB+4hqhDvNKIHlVIlyYZ+hvkh3xpOw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(55016002)(86362001)(66476007)(66946007)(66556008)(38350700002)(38100700002)(8886007)(83380400001)(966005)(54906003)(52116002)(8936002)(1076003)(508600001)(33656002)(186003)(2616005)(956004)(36756003)(6916009)(316002)(7696005)(8676002)(5660300002)(4326008)(26005)(2906002)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWpPejlNcDlIQ2c2dVUzU2lreTcxUHFtdTBBY3VaRzEzMGtEdCszSEVQYStK?= =?utf-8?B?RHo3T1hiR2tuTVpHZVA5Yk83OXNsbWswVk1zcE9oWVRjbU1LbkE5SldCQTd4?= =?utf-8?B?L2ZIOCt0dDhXeFZEQ3hQS1dOZno0THVZa05rR0t4cG9tdWQ2TjJwSzBvSVRE?= =?utf-8?B?b1M3djlaZ1VtczkzMit3bjRlcmFZc2gwNnlPU0FLc0J5Mi8xM25Bd1Q2S0kz?= =?utf-8?B?Z3NLaGY2cGlwcnZVZk9XQVc5TVZwUTM4ZjErVElMMkZjaE1Bd0IyZTZsVHVq?= =?utf-8?B?TURpK1NBZTlzVEhnUDVrUzR6Y1JIWG9kTjh1enB0Q3RqTjhtUVMwQXhUQ1F6?= =?utf-8?B?K0hFRnUzaFhDanR6Y050NHNNZEFjeEpzNFJsUVczZEJTdUxWU3Zxc0RNeGVV?= =?utf-8?B?cVFDODdqTUNjZjBXNUtSMTI1eDZzMldWYW15ZzJnSzhwd2dOM1B1L1RrNEVh?= =?utf-8?B?MVk2UWw5WlN2MllqQmwrZXVDOXNqeWFmajZZOHo4UCtQMEJ5emw0VHNtaEJz?= =?utf-8?B?bjkzaUpFSjFQd2trODdVaHNCRHRtMjV4TmNkc3BxQ0N5VzY2VElqNXNJcmNR?= =?utf-8?B?N1prRmhlMVoxb3lBb0ZpZXVPMFNRcSthN1ZpTmtHbXNDS3F6NW80dVoxV0hz?= =?utf-8?B?cm5oN2pOSFlVeXA3VmZMbytIZnNSeXNtaW9xcERMTklmSEVENExYOTE3L2sz?= =?utf-8?B?RFRsSldFaS9EZzFlYVIxTzc0Y0xDaldlbm1lMDVCVWQxdFVyOVZrT3ltY0d2?= =?utf-8?B?RG9CRU00dmZxN212bWF3SlhZOVNnOXdnWUllM2pBb1M0emZKRWpVUHlKb1Ay?= =?utf-8?B?aittanpNWGRTd3o3blRMc04wTGwyMWd0ckZueUNicFlNMlhLTTFKdnRFbkhG?= =?utf-8?B?Wnp5Q2IwQ3BXejRtR3JIWndyOGhPQkJySTgzQ2JJT3hteVAvZlYyWnpGVVJs?= =?utf-8?B?Mm1rZUl4OVEzNWljV0lpN3BKVmRFSnY1WDlGNVhKRUtNbnJlR0U5NFNUNHBv?= =?utf-8?B?UjRQMGJxSmRNOTJtVit6dDRLbHM3UVpZOXkxNXVQdU11NmQxSm1iVXdsUnVz?= =?utf-8?B?QmZlNkZmaWNNekVhNWNldGNoNUpZZ1FJSlF0NlBvVzMxckoxeEU3RGpYbG9P?= =?utf-8?B?VEFIUFFMQVdja05wRGR4aytOdllxclFCQlQwcEt2bXhrL01UcExSdTUxSTVO?= =?utf-8?B?Zm1NRTFtSU5vS01XUWJRKzM3YXlvaWtYajdhS21hL2lEL29HUmpISC8zRzBQ?= =?utf-8?B?Q2F3ZnY0SVRoemJUZGh6c056SzlZbXhvN296cDBHQnIrM1JwRG4yM1YvL05U?= =?utf-8?B?MVZNcXMvUitVcjc1R1kvQnJCdk43QnE3MnFIZCtFSFN5YjhmVVBpSzdzRkow?= =?utf-8?B?eklTYk5PbDFjM09WdWxuRkpHY2Ewb2U3eGhZQ2pjRUVSK3FGODFJdHRlVVM4?= =?utf-8?B?NitRbEpaelZYRVZpM1BYL0RhbUNzZFVBNk1WekwzQVBIU1BnTXIyRTRXQkVY?= =?utf-8?B?Mno3aU5wcFFmVUtCZ3R4cThaZ2g3WGYyK1BBbDBaV1gyeXdTNHRhay9UNGRH?= =?utf-8?B?Y08zbUtGaXdmekdXeFcwZkx6UE9ZaEEzV0JJbUpSejJkam5FMFY5YWFJWHpM?= =?utf-8?B?WVR3TFVWUm1WMzNJaG1LaUF6ejArZ3NtbEFQMWVnbWM4TzV2TisrY3pYK1pF?= =?utf-8?B?L21WL1VtN1gvRDNWK3kwMFI0Sm5vOTdDcldsZWtLMkEycXd3MlVMRkZmWnN1?= =?utf-8?Q?8vyCDFpHEXDVr2yYEmyrilncgDGH++tUvg5fo1r?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6847 Original-Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 102374d4-eff8-4a44-21b1-08d95cc205d6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0kPggwfWLz7TpeDlg0iJ5XHmDIAz7kIypCdX306tX3DP/I1/XWA9fNhUY/wWeyS68E2nS/QK1Q19DD0wCSeliDoP8q8Itib6sv4x5jJHCDO3mYQzaCtizCZXS0JeQOWPS8JHolK3VNUfTkk/wRNaar78wPPg3cgpnb5vkW85XwL5eekZXG59WrT6GVa4NpmkC0VMiS/AnJ/+Vri7bHrJ1BH2WJyRbOO12coMLwqTTy0+S+SJiQXLa71gfnhVxnK7ygXNTzNNH+p5bXzfJyfMd1lPZcIDf1cNtL/l4qZq5Yuww6AXc9bg/8MZmLyOFLHTe1QHgkWbdmgVI55aKCY97lt2yTnh7Zq938FpgdqztiHbMmSnpIbrccLNOPa/k2kEWRCfKe3pniVPu/SKk12jbKl0DBXcgkUg2GMsLPxV720dnIAV0jea6MXMSP4y/kbmXZhFiNdnnqeB41qE0aBWIG/N6GO1eChLb+9hHeSlUd7vOyZct84F33kVPAl8unN9+9xYKSGwVZpBGs00s45hWHIAQrGyPV5k+qcAd2SexaJ3q0uL/y9r5CyAe3QfD6kYnil/N8trG8fNon9v6FWGqtPnon+2CotqrwxAZMJMg8s5AqTZDo3CpYEkty+IUxYJclhTZwrl1o47wcnkAP86jO56XmZsNHtdt7nUzHTvBkdVbWtXhV2pNQFR2M3j3/wVrtUpuA4cKzuwa3LALyxqOrv0Gwu8GExRoLCFeb5cnS0Y2gHpfto+woDacZbqezgcqxP6m9DKy1mWuTKDRBzzjQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(39850400004)(136003)(46966006)(36840700001)(70586007)(26005)(82310400003)(4326008)(33656002)(956004)(356005)(86362001)(83380400001)(70206006)(55016002)(478600001)(1076003)(5660300002)(36860700001)(966005)(7696005)(8936002)(54906003)(336012)(47076005)(2616005)(2906002)(8886007)(44832011)(107886003)(8676002)(316002)(82740400003)(186003)(6862004)(36756003)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2021 12:17:53.5103 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee0fee6f-346c-4681-2a14-08d95cc20b85 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5194 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Szabolcs Nagy via Libc-alpha Reply-To: Szabolcs Nagy Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" The 08/10/2021 14:14, Fangrui Song via Libc-alpha wrote: > On 2021-08-10, Fangrui Song wrote: > > TLSDESC is the default on aarch64. Clang doesn't support > > -mtls-dialect=trad. Its integrated assembler doesn't support the > > marker. LLD's doesn't support R_AARCH64_TLSGD_*/R_AARCH64_TLSLD_* > > relocations. Just skip the tests. > > > > With https://sourceware.org/pipermail/libc-alpha/2021-August/129966.html > > ("aarch64: Make elf_machine_{load_address, dynamic} robust [BZ #28203]"), > > if we allow LLD in configure.ac, > > `make check` test results of LLD are on par with GNU ld. > > I messed up in the diff. > The correct diff needs `#include ` to make HAVE_TRAD_TLS > defined. the fixed patch looks good to me. but now i looked at elf/tls-macros.h and it seems to be for when there is on compiler support. i think the only thing the compiler does not support is mixing different tls access models to a variable in the same tu, but i'm not sure if that's useful or necessary for the tests: we can use many files with different -ftls-model= or __attribute__((tls_model(...))). is there a need for these hard to maintain macros?