* [PATCH] Make mcheck tests conditional on GLIBC_2.24 or earlier
@ 2021-07-09 11:17 Siddhesh Poyarekar via Libc-alpha
0 siblings, 0 replies; only message in thread
From: Siddhesh Poyarekar via Libc-alpha @ 2021-07-09 11:17 UTC (permalink / raw)
To: libc-alpha
Targets with base versions later than 2.24 won't have
__malloc_initialize_hook because of which the tests will essentially
be the same as the regular malloc tests. Avoid running them instead
and save time.
---
malloc/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/malloc/Makefile b/malloc/Makefile
index 37a9a4efab..76c996bb4d 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -77,6 +77,8 @@ tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \
# Run all tests with MALLOC_CHECK_=3
tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests))
+# -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24.
+ifeq ($(have-GLIBC_2.24)$(build-shared),yesyes)
# Tests that don't play well with mcheck. They are either bugs in mcheck or
# the tests expect specific internal behavior that is changed due to linking to
# libmcheck.a.
@@ -97,6 +99,7 @@ tests-exclude-mcheck = tst-mallocstate \
tst-realloc
tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
+endif
routines = malloc morecore mcheck mtrace obstack reallocarray \
scratch_buffer_dupfree \
--
2.31.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-09 11:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 11:17 [PATCH] Make mcheck tests conditional on GLIBC_2.24 or earlier Siddhesh Poyarekar via Libc-alpha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).