From: Lukasz Majewski <lukma@denx.de>
To: Alistair Francis <alistair.francis@wdc.com>
Cc: libc-alpha@sourceware.org, alistair23@gmail.com
Subject: Re: [PATCH v3 4/8] sysv: Define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64
Date: Sat, 15 Feb 2020 15:03:34 +0100 [thread overview]
Message-ID: <20200215150334.233d3472@jawa> (raw)
In-Reply-To: <20200214163134.31601-5-alistair.francis@wdc.com>
[-- Attachment #1: Type: text/plain, Size: 5640 bytes --]
On Fri, 14 Feb 2020 08:31:30 -0800
Alistair Francis <alistair.francis@wdc.com> wrote:
> On y2038 safe 32-bit systems the Linux kernel expects itimerval
> and rusage to use a 32-bit time_t, even though the other time_t's
> are 64-bit.
>
> There are also other occurances where the time passed to the kernel
> via timeval doesn't match the wordsize.
>
> To handle these cases let's define a new macro
> __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64. This macro specifies if the
> kernel's old_timeval matches the new timeval64. This should be true
> for 64-bit architectures (expect for Alpha) and x32.
Reviewed-by: Lukasz Majewski <lukma@denx.de>
> ---
> bits/typesizes.h | 6 ++++++
> sysdeps/unix/sysv/linux/alpha/bits/typesizes.h | 3 +++
> sysdeps/unix/sysv/linux/generic/bits/typesizes.h | 7 +++++++
> sysdeps/unix/sysv/linux/s390/bits/typesizes.h | 6 ++++++
> sysdeps/unix/sysv/linux/sparc/bits/typesizes.h | 6 ++++++
> sysdeps/unix/sysv/linux/x86/bits/typesizes.h | 3 +++
> 6 files changed, 31 insertions(+)
>
> diff --git a/bits/typesizes.h b/bits/typesizes.h
> index 599408973e..8f16903a21 100644
> --- a/bits/typesizes.h
> +++ b/bits/typesizes.h
> @@ -76,10 +76,16 @@
>
> /* And for fsblkcnt_t, fsblkcnt64_t, fsfilcnt_t and fsfilcnt64_t. */
> # define __STATFS_MATCHES_STATFS64 1
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 1
> #else
> # define __RLIM_T_MATCHES_RLIM64_T 0
>
> # define __STATFS_MATCHES_STATFS64 0
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 0
> #endif
>
> /* Number of descriptors that can fit in an `fd_set'. */
> diff --git a/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h
> b/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h index
> 28ee3e5920..e5d7774468 100644 ---
> a/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h +++
> b/sysdeps/unix/sysv/linux/alpha/bits/typesizes.h @@ -73,6 +73,9 @@
> /* Not for fsblkcnt_t, fsblkcnt64_t, fsfilcnt_t and fsfilcnt64_t. */
> # define __STATFS_MATCHES_STATFS64 0
>
> +/* And for getitimer, setitimer and rusage */
> +#define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 0
> +
> /* Number of descriptors that can fit in an `fd_set'. */
> #define __FD_SETSIZE 1024
>
> diff --git a/sysdeps/unix/sysv/linux/generic/bits/typesizes.h
> b/sysdeps/unix/sysv/linux/generic/bits/typesizes.h index
> 7c963e523e..48727c1da7 100644 ---
> a/sysdeps/unix/sysv/linux/generic/bits/typesizes.h +++
> b/sysdeps/unix/sysv/linux/generic/bits/typesizes.h @@ -77,11 +77,18 @@
>
> /* And for fsblkcnt_t, fsblkcnt64_t, fsfilcnt_t and fsfilcnt64_t. */
> # define __STATFS_MATCHES_STATFS64 1
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 1
> #else
> # define __RLIM_T_MATCHES_RLIM64_T 0
>
> # define __STATFS_MATCHES_STATFS64 0
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 0
> #endif
> +
> /* Number of descriptors that can fit in an `fd_set'. */
> #define __FD_SETSIZE 1024
>
> diff --git a/sysdeps/unix/sysv/linux/s390/bits/typesizes.h
> b/sysdeps/unix/sysv/linux/s390/bits/typesizes.h index
> e775e460bb..2bc87c1079 100644 ---
> a/sysdeps/unix/sysv/linux/s390/bits/typesizes.h +++
> b/sysdeps/unix/sysv/linux/s390/bits/typesizes.h @@ -82,10 +82,16 @@
>
> /* And for fsblkcnt_t, fsblkcnt64_t, fsfilcnt_t and fsfilcnt64_t. */
> # define __STATFS_MATCHES_STATFS64 1
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 1
> #else
> # define __RLIM_T_MATCHES_RLIM64_T 0
>
> # define __STATFS_MATCHES_STATFS64 0
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 0
> #endif
>
> /* Number of descriptors that can fit in an `fd_set'. */
> diff --git a/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h
> b/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h index
> ac48c23e37..288a902b5f 100644 ---
> a/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h +++
> b/sysdeps/unix/sysv/linux/sparc/bits/typesizes.h @@ -76,10 +76,16 @@
>
> /* And for fsblkcnt_t, fsblkcnt64_t, fsfilcnt_t and fsfilcnt64_t. */
> # define __STATFS_MATCHES_STATFS64 1
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 1
> #else
> # define __RLIM_T_MATCHES_RLIM64_T 0
>
> # define __STATFS_MATCHES_STATFS64 0
> +
> +/* And for getitimer, setitimer and rusage */
> +# define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 0
> #endif
>
> /* Number of descriptors that can fit in an `fd_set'. */
> diff --git a/sysdeps/unix/sysv/linux/x86/bits/typesizes.h
> b/sysdeps/unix/sysv/linux/x86/bits/typesizes.h index
> 87c50a4f32..f68dfecc90 100644 ---
> a/sysdeps/unix/sysv/linux/x86/bits/typesizes.h +++
> b/sysdeps/unix/sysv/linux/x86/bits/typesizes.h @@ -94,6 +94,9 @@
> # define __STATFS_MATCHES_STATFS64 0
> #endif
>
> +/* And for getitimer, setitimer and rusage */
> +#define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 1
> +
> /* Number of descriptors that can fit in an `fd_set'. */
> #define __FD_SETSIZE 1024
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-15 14:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 16:31 [PATCH v3 0/8] Always use 32-bit time_t for certain syscalls Alistair Francis
2020-02-14 16:31 ` [PATCH v3 1/8] sysv/linux: Rename alpha functions to be alpha specific Alistair Francis
2020-02-15 13:54 ` Lukasz Majewski
2020-02-14 16:31 ` [PATCH v3 2/8] time: Add a timeval with a 32-bit tv_sec and tv_usec Alistair Francis
2020-02-15 13:57 ` Lukasz Majewski
2020-02-14 16:31 ` [PATCH v3 3/8] time: Add a __itimerval64 struct Alistair Francis
2020-02-14 16:31 ` [PATCH v3 4/8] sysv: Define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 Alistair Francis
2020-02-15 14:03 ` Lukasz Majewski [this message]
2020-02-14 16:31 ` [PATCH v3 5/8] linux: Use long time_t __getitimer/__setitimer Alistair Francis
2020-02-15 16:26 ` Lukasz Majewski
2020-02-18 18:54 ` Alistair Francis
2020-02-14 16:31 ` [PATCH v3 6/8] resource: Add a __rusage64 struct Alistair Francis
2020-02-14 16:31 ` [PATCH v3 7/8] linux: Use long time_t for wait4/getrusage Alistair Francis
2020-02-15 16:27 ` Lukasz Majewski
2020-02-16 16:30 ` Lukasz Majewski
2020-02-18 23:04 ` Alistair Francis
2020-02-14 16:31 ` [PATCH v3 8/8] sysv/alpha: Use generic __timeval32 and helpers Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215150334.233d3472@jawa \
--to=lukma@denx.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).