From: Alistair Francis <alistair.francis@wdc.com>
To: libc-alpha@sourceware.org
Cc: alistair23@gmail.com, Alistair Francis <alistair.francis@wdc.com>
Subject: [PATCH v3 0/8] Always use 32-bit time_t for certain syscalls
Date: Fri, 14 Feb 2020 08:31:26 -0800 [thread overview]
Message-ID: <20200214163134.31601-1-alistair.francis@wdc.com> (raw)
On y2038 safe 32-bit systems the Linux kernel expects itimerval
and rusage to use a 32-bit time_t, even though the other time_t's
are 64-bit.
This series converts getitimer, setitimer, getrusage and wait4 to be
both y2038 safe and pass a 32-bit time_t based on the
__KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 macro. On 32-bit systems
we will pass a 32-bit time to the kernel (no matter the time_t size). This is
no change for most 64-bit architectures or 32-bit architectures with a 32-bit time_t.
We can also remove the old Alpha functions as this is now handled genericly.
I don't have a way to test this on Alpha, would someone mind testing it for me?
This follows the standard y2038 conversion so that we don't break
backwards compatibility but we expose a 64-bit version for y2038 safe
architectrures (like RV32).
This series was tested by running:
./scripts/build-many-glibcs.py ... compilers
./scripts/build-many-glibcs.py ... glibcs
on my x86_64 machine.
I also ran make check on RV32 and I only see a total of 10 test failures.
Alistair Francis (8):
sysv/linux: Rename alpha functions to be alpha specific
time: Add a timeval with a 32-bit tv_sec and tv_usec
time: Add a __itimerval64 struct
sysv: Define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64
linux: Use long time_t __getitimer/__setitimer
resource: Add a __rusage64 struct
linux: Use long time_t for wait4/getrusage
sysv/alpha: Use generic __timeval32 and helpers
bits/typesizes.h | 6 +
include/sys/resource.h | 120 ++++++++++++++++++
include/time.h | 71 +++++++++++
.../unix/sysv/linux/alpha/bits/typesizes.h | 3 +
sysdeps/unix/sysv/linux/alpha/osf_adjtime.c | 7 +-
sysdeps/unix/sysv/linux/alpha/osf_getitimer.c | 3 +-
sysdeps/unix/sysv/linux/alpha/osf_getrusage.c | 8 +-
.../unix/sysv/linux/alpha/osf_gettimeofday.c | 4 +-
sysdeps/unix/sysv/linux/alpha/osf_setitimer.c | 5 +-
.../unix/sysv/linux/alpha/osf_settimeofday.c | 4 +-
sysdeps/unix/sysv/linux/alpha/osf_utimes.c | 4 +-
sysdeps/unix/sysv/linux/alpha/osf_wait4.c | 8 +-
.../unix/sysv/linux/generic/bits/typesizes.h | 7 +
sysdeps/unix/sysv/linux/getitimer.c | 61 +++++++++
sysdeps/unix/sysv/linux/getrusage.c | 58 +++++++++
sysdeps/unix/sysv/linux/s390/bits/typesizes.h | 6 +
sysdeps/unix/sysv/linux/setitimer.c | 95 ++++++++++++++
.../unix/sysv/linux/sparc/bits/typesizes.h | 6 +
.../unix/sysv/linux/{alpha => }/tv32-compat.h | 86 +++++--------
sysdeps/unix/sysv/linux/wait4.c | 49 ++++++-
sysdeps/unix/sysv/linux/x86/bits/typesizes.h | 3 +
21 files changed, 541 insertions(+), 73 deletions(-)
create mode 100644 sysdeps/unix/sysv/linux/getitimer.c
create mode 100644 sysdeps/unix/sysv/linux/getrusage.c
create mode 100644 sysdeps/unix/sysv/linux/setitimer.c
rename sysdeps/unix/sysv/linux/{alpha => }/tv32-compat.h (59%)
--
2.25.0
next reply other threads:[~2020-02-14 16:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 16:31 Alistair Francis [this message]
2020-02-14 16:31 ` [PATCH v3 1/8] sysv/linux: Rename alpha functions to be alpha specific Alistair Francis
2020-02-15 13:54 ` Lukasz Majewski
2020-02-14 16:31 ` [PATCH v3 2/8] time: Add a timeval with a 32-bit tv_sec and tv_usec Alistair Francis
2020-02-15 13:57 ` Lukasz Majewski
2020-02-14 16:31 ` [PATCH v3 3/8] time: Add a __itimerval64 struct Alistair Francis
2020-02-14 16:31 ` [PATCH v3 4/8] sysv: Define __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 Alistair Francis
2020-02-15 14:03 ` Lukasz Majewski
2020-02-14 16:31 ` [PATCH v3 5/8] linux: Use long time_t __getitimer/__setitimer Alistair Francis
2020-02-15 16:26 ` Lukasz Majewski
2020-02-18 18:54 ` Alistair Francis
2020-02-14 16:31 ` [PATCH v3 6/8] resource: Add a __rusage64 struct Alistair Francis
2020-02-14 16:31 ` [PATCH v3 7/8] linux: Use long time_t for wait4/getrusage Alistair Francis
2020-02-15 16:27 ` Lukasz Majewski
2020-02-16 16:30 ` Lukasz Majewski
2020-02-18 23:04 ` Alistair Francis
2020-02-14 16:31 ` [PATCH v3 8/8] sysv/alpha: Use generic __timeval32 and helpers Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214163134.31601-1-alistair.francis@wdc.com \
--to=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).