[review v5] Lazy binding failures during dlopen/dlclose must be fatal [BZ #24304]

["Carlos O'Donell (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Carlos O'Donell has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/467
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

Additional news entry is OK (matches what Adhemerval is doing). Please feel free to split this out as a distinct commit if you like though. Otherwise it slows down this review. 

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

| --- NEWS
| +++ NEWS
| @@ -74,15 +74,21 @@ * The settimeofday function can still be used to set a system-wide time
|    Note that settimeofday itself is obsolescent according to POSIX.
|    Programs that set the system time should use clock_settime and/or
|    the adjtime family of functions instead.  We may also cease to make
|    settimeofday available to newly linked binaries after there is a
|    replacement for Linux's time-zone-like offset API.
|  
|  * The obsolete functions ftime has been deprecated and will be removed from
|    a future version of glibc.  Application should use clock_gettime instead.
|  
|  * The sparc*-*linux-gnu configurations targeting v7 or order architecture
|    are no longer supported.  For v8 only implementations with native CAS
|    instruction are still supported (such as LEON).

PS5, Line 85:

OK.

|  
| +* If a lazy binding failure happens during dlopen, during the execution of
| +  an ELF constructor, the process is now terminated.  Previously, the
| +  dynamic loader would return NULL from dlopen, with the lazy binding error
| +  captured in a dlerror message.  In general, this is unsafe because
| +  resetting the stack in an arbitrary function call is not possible.
| +
|  Changes to build and runtime requirements:
|  

-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I6b1addfe2e30f50a1781595f046f44173db9491a
Gerrit-Change-Number: 467
Gerrit-PatchSet: 5
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Wed, 27 Nov 2019 19:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment