From: "Florian Weimer (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Cc: Carlos O'Donell <carlos@redhat.com>
Subject: [review v3] Lazy binding failures during dlopen/dlclose must be fatal [BZ #24304]
Date: Mon, 18 Nov 2019 12:01:05 -0500 [thread overview]
Message-ID: <20191118170107.6E3532816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572549639000.I6b1addfe2e30f50a1781595f046f44173db9491a@gnutoolchain-gerrit.osci.io>
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/467
......................................................................
Patch Set 3: Code-Review-2
> Please update the packaging changes here:
> https://www.sourceware.org/glibc/wiki/Release/2.31
> to indicate that the semantic change has happened and to watch out for it.
>
> I think we should have a NEWS item for this, but you can commit that in a followup if you want.
I need to rebase the series anyway, so I can as well add a NEWS entry.
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I6b1addfe2e30f50a1781595f046f44173db9491a
Gerrit-Change-Number: 467
Gerrit-PatchSet: 3
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 17:01:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-18 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 19:20 [review] Lazy binding failures during dlopen/dlclose must be fatal [BZ #24304] Florian Weimer (Code Review)
2019-11-13 12:57 ` [review v2] " Florian Weimer (Code Review)
2019-11-15 16:02 ` [review v3] " Florian Weimer (Code Review)
2019-11-18 16:23 ` Carlos O'Donell (Code Review)
2019-11-18 17:01 ` Florian Weimer (Code Review) [this message]
2019-11-27 15:20 ` Florian Weimer (Code Review)
2019-11-27 15:56 ` [review v4] " Florian Weimer (Code Review)
2019-11-27 18:34 ` Carlos O'Donell (Code Review)
2019-11-27 19:00 ` [review v5] " Florian Weimer (Code Review)
2019-11-27 19:04 ` Carlos O'Donell (Code Review)
2019-11-27 20:30 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118170107.6E3532816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=gnutoolchain-gerrit@osci.io \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).