From: "Szabolcs Nagy (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: [review] dlsym: Do not determine caller link map if not needed
Date: Fri, 15 Nov 2019 07:14:05 -0500 [thread overview]
Message-ID: <20191115121405.EC28920AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573224613000.Ide5d9e2cc7ac25a0ffae8fb4c26def0c898efa29@gnutoolchain-gerrit.osci.io>
Szabolcs Nagy has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/528
......................................................................
Patch Set 1: Code-Review+1
the optimization makes sense to me, and the code looks correct.
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Ide5d9e2cc7ac25a0ffae8fb4c26def0c898efa29
Gerrit-Change-Number: 528
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Szabolcs Nagy <szabolcs.nagy@arm.com>
Gerrit-Comment-Date: Fri, 15 Nov 2019 12:14:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-15 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 14:50 [review] dlsym: Do not determine caller link map if not needed Florian Weimer (Code Review)
2019-11-15 12:14 ` Szabolcs Nagy (Code Review) [this message]
2019-11-27 18:47 ` Carlos O'Donell (Code Review)
2019-11-27 18:58 ` [review v2] " Florian Weimer (Code Review)
2019-11-27 19:01 ` Carlos O'Donell (Code Review)
2019-11-27 19:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115121405.EC28920AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=fweimer@redhat.com \
--cc=gnutoolchain-gerrit@osci.io \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).