From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6D9251F4B5 for ; Fri, 15 Nov 2019 12:14:15 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; q=dns; s=default; b=TUjkR0AWCZ4J2zMs2ekIhL72NU2AoOz JkLtpk3q2Cxch7zdQRmmTndBU+p9BDAe5zLz9Qw3W0SZu/his6PN/9O8Tglr0o9I Ff2izjN7Q/zX3k1zyZB5MojjvfT+MJYpvtoANcr1PerdcAoTw42/DUW33tAFbUWr 2DS8iIapHhRA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; s=default; bh=SQzF+y84mJadwXGDClsI3RG5lYs=; b=Aky0j CR/svHair/vcHaefhhNcdrux5T9C5ZDgHWcxhbegDncvJRCHbF59P9FjTUlgnTDm ZRc3kGG9VB8if7VYVrQ/a3KEexrqmSZZPK5eoSsLFPuRFKLuSAaizEVGGgBPjTJS iq3wAF+2HG9l1Ih2zmAtnrLop3774PPUTjEyrY= Received: (qmail 105691 invoked by alias); 15 Nov 2019 12:14:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 105681 invoked by uid 89); 15 Nov 2019 12:14:12 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.osci.io X-Gerrit-PatchSet: 1 Date: Fri, 15 Nov 2019 07:14:05 -0500 From: "Szabolcs Nagy (Code Review)" To: Florian Weimer , libc-alpha@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] dlsym: Do not determine caller link map if not needed X-Gerrit-Change-Id: Ide5d9e2cc7ac25a0ffae8fb4c26def0c898efa29 X-Gerrit-Change-Number: 528 X-Gerrit-ChangeURL: X-Gerrit-Commit: f4adfc9645132874eb4b57e0c76f627db102dddd In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 15 Nov 2019 07:14:05 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191115121405.EC28920AF6@gnutoolchain-gerrit.osci.io> Szabolcs Nagy has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/528 ...................................................................... Patch Set 1: Code-Review+1 the optimization makes sense to me, and the code looks correct. -- Gerrit-Project: glibc Gerrit-Branch: master Gerrit-Change-Id: Ide5d9e2cc7ac25a0ffae8fb4c26def0c898efa29 Gerrit-Change-Number: 528 Gerrit-PatchSet: 1 Gerrit-Owner: Florian Weimer Gerrit-Reviewer: Szabolcs Nagy Gerrit-Comment-Date: Fri, 15 Nov 2019 12:14:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment