From: "Florian Weimer (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Cc: Carlos O'Donell <carlos@redhat.com>
Subject: [review] login: Use pread64 in utmp implementation
Date: Tue, 12 Nov 2019 14:12:51 -0500 [thread overview]
Message-ID: <20191112191252.4B49020AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573559410000.If21ea0c162c38830a89331ea93cddec14c0974de@gnutoolchain-gerrit.osci.io>
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/615
......................................................................
Patch Set 1:
(15 comments)
Acking comments.
| --- login/utmp_file.c
| +++ login/utmp_file.c
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: If21ea0c162c38830a89331ea93cddec14c0974de
Gerrit-Change-Number: 615
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 19:12:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Carlos O'Donell <carlos@redhat.com>
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-12 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 11:50 [review] login: Use pread64 in utmp implementation Florian Weimer (Code Review)
2019-11-12 17:21 ` Carlos O'Donell (Code Review)
2019-11-12 19:12 ` Florian Weimer (Code Review) [this message]
2019-11-12 19:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112191252.4B49020AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=gnutoolchain-gerrit@osci.io \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).