From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D49931F4B5 for ; Tue, 12 Nov 2019 19:12:57 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; q=dns; s=default; b=GmQUOy2ng8xBBME0GdaEpiTmPt2ogNX SRhU8tIJc20nXRxwh3M5QIjbAzV+nbS81NuH6FAYQ6P7yahVf545VgMGEZ6Yyi6P IIsA3nj7eyswyRRAPeCdhWbzBF/aIfSKUYP4tibDvidesZbynkxTeNB3Beu3ki92 HmpPyo3MEDYg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; s=default; bh=0bp3ZgCPTP7+jsT49FKmwz7oJr4=; b=i/AZq 0i3aPiqp2u6WDcGLS3H91f4qWAwvzCO9wSK65rz+FoCteUW5Gjw3MkAij4SljSDx 9rTj36uY7FEbiH0phJPcFSk+gwtJHC/UvGkLA+Gm9dVbZwqEhvdo9smZmvAbc976 MLdNbKZJxOOWkuLpszzHAcekiIPn7CywGpq/Is= Received: (qmail 38362 invoked by alias); 12 Nov 2019 19:12:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 38354 invoked by uid 89); 12 Nov 2019 19:12:55 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.osci.io X-Gerrit-PatchSet: 1 Date: Tue, 12 Nov 2019 14:12:51 -0500 From: "Florian Weimer (Code Review)" To: Florian Weimer , libc-alpha@sourceware.org Cc: Carlos O'Donell Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] login: Use pread64 in utmp implementation X-Gerrit-Change-Id: If21ea0c162c38830a89331ea93cddec14c0974de X-Gerrit-Change-Number: 615 X-Gerrit-ChangeURL: X-Gerrit-Commit: d6f3c228c5aa01739c447fe0d0d171283fbe2017 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Nov 2019 14:12:51 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191112191252.4B49020AF6@gnutoolchain-gerrit.osci.io> Florian Weimer has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/615 ...................................................................... Patch Set 1: (15 comments) Acking comments. | --- login/utmp_file.c | +++ login/utmp_file.c -- Gerrit-Project: glibc Gerrit-Branch: master Gerrit-Change-Id: If21ea0c162c38830a89331ea93cddec14c0974de Gerrit-Change-Number: 615 Gerrit-PatchSet: 1 Gerrit-Owner: Florian Weimer Gerrit-Reviewer: Carlos O'Donell Gerrit-Reviewer: Florian Weimer Gerrit-Comment-Date: Tue, 12 Nov 2019 19:12:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Carlos O'Donell Gerrit-MessageType: comment