unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [review] support: Include <limits.h> in support_small_stack_thread_attribute.c
@ 2019-11-12 18:39 Florian Weimer (Code Review)
  2019-11-12 18:47 ` [review v2] " Florian Weimer (Code Review)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Florian Weimer (Code Review) @ 2019-11-12 18:39 UTC (permalink / raw)
  To: libc-alpha; +Cc: Florian Weimer

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/619
......................................................................

support: Include <limits.h> in support_small_stack_thread_attribute.c

Change-Id: Idc212c887ff178aa67f22cc99def3383dae99040
---
M support/support_small_stack_thread_attribute.c
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/support/support_small_stack_thread_attribute.c b/support/support_small_stack_thread_attribute.c
index a65097d..206dacd 100644
--- a/support/support_small_stack_thread_attribute.c
+++ b/support/support_small_stack_thread_attribute.c
@@ -18,6 +18,7 @@
 
 #include <support/xthread.h>
 #include <allocate_once.h>
+#include <limits.h>
 
 static void *
 allocate (void *closure)

-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Idc212c887ff178aa67f22cc99def3383dae99040
Gerrit-Change-Number: 619
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-MessageType: newchange

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [review v2] support: Include <limits.h> in support_small_stack_thread_attribute.c
  2019-11-12 18:39 [review] support: Include <limits.h> in support_small_stack_thread_attribute.c Florian Weimer (Code Review)
@ 2019-11-12 18:47 ` Florian Weimer (Code Review)
  2019-11-12 18:48 ` [review v3] support: Include <limits.h> in support_set_small_thread_stack_size.c Florian Weimer (Code Review)
  2019-11-12 19:05 ` Florian Weimer (Code Review)
  2 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer (Code Review) @ 2019-11-12 18:47 UTC (permalink / raw)
  To: Florian Weimer, libc-alpha

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/619
......................................................................

support: Include <limits.h> in support_small_stack_thread_attribute.c

Change-Id: Idc212c887ff178aa67f22cc99def3383dae99040
---
M support/support_set_small_thread_stack_size.c
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/support/support_set_small_thread_stack_size.c b/support/support_set_small_thread_stack_size.c
index 23189fd..c4f8fea 100644
--- a/support/support_set_small_thread_stack_size.c
+++ b/support/support_set_small_thread_stack_size.c
@@ -16,6 +16,7 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
+#include <limits.h>
 #include <pthread.h>
 #include <support/xthread.h>
 #include <sys/param.h>

-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Idc212c887ff178aa67f22cc99def3383dae99040
Gerrit-Change-Number: 619
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-MessageType: newpatchset

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [review v3] support: Include <limits.h> in support_set_small_thread_stack_size.c
  2019-11-12 18:39 [review] support: Include <limits.h> in support_small_stack_thread_attribute.c Florian Weimer (Code Review)
  2019-11-12 18:47 ` [review v2] " Florian Weimer (Code Review)
@ 2019-11-12 18:48 ` Florian Weimer (Code Review)
  2019-11-12 19:05 ` Florian Weimer (Code Review)
  2 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer (Code Review) @ 2019-11-12 18:48 UTC (permalink / raw)
  To: Florian Weimer, libc-alpha

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/619
......................................................................

support: Include <limits.h> in support_set_small_thread_stack_size.c

Change-Id: Idc212c887ff178aa67f22cc99def3383dae99040
---
M support/support_set_small_thread_stack_size.c
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/support/support_set_small_thread_stack_size.c b/support/support_set_small_thread_stack_size.c
index 23189fd..c4f8fea 100644
--- a/support/support_set_small_thread_stack_size.c
+++ b/support/support_set_small_thread_stack_size.c
@@ -16,6 +16,7 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
+#include <limits.h>
 #include <pthread.h>
 #include <support/xthread.h>
 #include <sys/param.h>

-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Idc212c887ff178aa67f22cc99def3383dae99040
Gerrit-Change-Number: 619
Gerrit-PatchSet: 3
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-MessageType: newpatchset

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [review v3] support: Include <limits.h> in support_set_small_thread_stack_size.c
  2019-11-12 18:39 [review] support: Include <limits.h> in support_small_stack_thread_attribute.c Florian Weimer (Code Review)
  2019-11-12 18:47 ` [review v2] " Florian Weimer (Code Review)
  2019-11-12 18:48 ` [review v3] support: Include <limits.h> in support_set_small_thread_stack_size.c Florian Weimer (Code Review)
@ 2019-11-12 19:05 ` Florian Weimer (Code Review)
  2 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer (Code Review) @ 2019-11-12 19:05 UTC (permalink / raw)
  To: Florian Weimer, libc-alpha

Florian Weimer has abandoned this change. ( https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/619 )

Change subject: support: Include <limits.h> in support_set_small_thread_stack_size.c
......................................................................


Abandoned

Sorry for using Gerrit to shuffle patches between systems. The <limits.h> include is not the correct fix, as it turns out.
-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Idc212c887ff178aa67f22cc99def3383dae99040
Gerrit-Change-Number: 619
Gerrit-PatchSet: 3
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-MessageType: abandon

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-12 19:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 18:39 [review] support: Include <limits.h> in support_small_stack_thread_attribute.c Florian Weimer (Code Review)
2019-11-12 18:47 ` [review v2] " Florian Weimer (Code Review)
2019-11-12 18:48 ` [review v3] support: Include <limits.h> in support_set_small_thread_stack_size.c Florian Weimer (Code Review)
2019-11-12 19:05 ` Florian Weimer (Code Review)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).