From: "Szabolcs Nagy (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: [review v2] slotinfo in struct dtv_slotinfo_list should be flexible array [BZ #25...
Date: Tue, 12 Nov 2019 05:40:08 -0500 [thread overview]
Message-ID: <20191112104008.B3B3B20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572801105000.I51be146a7857186a4ede0bb40b332509487bdde8@gnutoolchain-gerrit.osci.io>
Szabolcs Nagy has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/489
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
two nits, otherwise ok.
| --- csu/libc-tls.c
| +++ csu/libc-tls.c
| @@ -199,18 +193,18 @@ #endif
| /* Update the executable's link map with enough information to make
| the TLS routines happy. */
| main_map->l_tls_align = align;
| main_map->l_tls_blocksize = memsz;
| main_map->l_tls_initimage = initimage;
| main_map->l_tls_initimage_size = filesz;
| main_map->l_tls_modid = 1;
|
| init_slotinfo ();
| // static_slotinfo.si.slotinfo[1].gen = 0; already zero
PS2, Line 202:
.si in the comment is wrong
| - static_slotinfo.si.slotinfo[1].map = main_map;
| + static_slotinfo.slotinfo[1].map = main_map;
|
| memsz = roundup (memsz, align ?: 1);
|
| #if TLS_DTV_AT_TP
| memsz += tcb_offset;
| #endif
|
| --- nptl_db/db_info.c
| +++ nptl_db/db_info.c
| @@ -49,15 +49,18 @@ #define schedparam_sched_priority schedparam.sched_priority
|
| #define eventbuf_eventmask eventbuf.eventmask
| #define eventbuf_eventmask_event_bits eventbuf.eventmask.event_bits
|
| #define DESC(name, offset, obj) \
| DB_DEFINE_DESC (name, 8 * sizeof (obj), 1, offset);
| #define ARRAY_DESC(name, offset, obj) \
| DB_DEFINE_DESC (name, \
| - 8 * sizeof (obj)[0], sizeof (obj) / sizeof (obj)[0], \
| + 8 * sizeof (obj)[0], sizeof (obj) / sizeof (obj)[0], \
PS2, Line 57:
is this whitespace change useful?
| offset);
| +/* Flexible arrays do not have a length that can be determined. */
| +#define FLEXIBLE_ARRAY_DESC(name, offset, obj) \
| + DB_DEFINE_DESC (name, 8 * sizeof (obj)[0], 0, offset);
|
| #if TLS_TCB_AT_TP
| # define dtvp header.dtv
| #elif TLS_DTV_AT_TP
| /* Special case hack. If TLS_TCB_SIZE == 0 (on PowerPC), there is no TCB
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I51be146a7857186a4ede0bb40b332509487bdde8
Gerrit-Change-Number: 489
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Szabolcs Nagy <szabolcs.nagy@arm.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 10:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-12 10:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 17:11 [review] slotinfo in struct dtv_slotinfo_list should be flexible array [BZ #25 Florian Weimer (Code Review)
2019-11-06 16:12 ` Szabolcs Nagy
2019-11-06 16:21 ` Florian Weimer
2019-11-11 15:09 ` Szabolcs Nagy
2019-11-11 15:12 ` Florian Weimer
2019-11-11 21:41 ` Sergio Durigan Junior
2019-11-12 10:22 ` Szabolcs Nagy
2019-11-12 10:35 ` Florian Weimer
2019-11-09 11:44 ` [review v2] " Florian Weimer (Code Review)
2019-11-12 10:40 ` Szabolcs Nagy (Code Review) [this message]
2019-11-12 11:47 ` [review v3] " Florian Weimer (Code Review)
2019-11-12 17:29 ` Joseph Myers
2019-11-12 17:42 ` Sandra Loosemore
2019-11-12 18:04 ` Joseph Myers
2019-11-12 18:42 ` Florian Weimer
2019-11-12 20:59 ` Sandra Loosemore
2019-11-13 5:47 ` Florian Weimer
2019-11-13 16:04 ` Sandra Loosemore
2019-11-13 16:25 ` Florian Weimer
2019-11-13 16:06 ` Jeff Law
2019-11-12 22:14 ` Carlos O'Donell
2019-11-12 22:18 ` Florian Weimer
2019-11-12 22:24 ` Carlos O'Donell
2019-11-12 22:26 ` Florian Weimer
2019-11-12 22:39 ` Joseph Myers
2019-11-13 6:18 ` Florian Weimer
2019-11-13 16:05 ` Jeff Law
2019-11-12 23:12 ` Sandra Loosemore
2019-11-12 23:15 ` Joseph Myers
2019-11-12 12:53 ` Szabolcs Nagy (Code Review)
2019-11-12 13:00 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-12 13:00 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112104008.B3B3B20AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=fweimer@redhat.com \
--cc=gnutoolchain-gerrit@osci.io \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).